Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1515543002: Close the shell when all activities are destroyed. (Closed)

Created:
5 years ago by etiennej
Modified:
5 years ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
git@github.com:domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
M shell/android/apk/src/org/chromium/mojo/shell/ShellService.java View 2 chunks +9 lines, -0 lines 0 comments Download
M shell/android/main.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
etiennej
5 years ago (2015-12-09 11:58:44 UTC) #1
qsr
https://codereview.chromium.org/1515543002/diff/1/shell/android/main.cc File shell/android/main.cc (right): https://codereview.chromium.org/1515543002/diff/1/shell/android/main.cc#newcode350 shell/android/main.cc:350: FROM_HERE, base::Bind(&QuitShellMessageLoopCallback)); Why not use MessageLoop::QuitClosure() instead?
5 years ago (2015-12-09 12:00:01 UTC) #2
etiennej
https://codereview.chromium.org/1515543002/diff/1/shell/android/main.cc File shell/android/main.cc (right): https://codereview.chromium.org/1515543002/diff/1/shell/android/main.cc#newcode350 shell/android/main.cc:350: FROM_HERE, base::Bind(&QuitShellMessageLoopCallback)); On 2015/12/09 12:00:01, qsr wrote: > Why ...
5 years ago (2015-12-09 12:09:26 UTC) #3
qsr
lgtm
5 years ago (2015-12-09 12:10:21 UTC) #4
etiennej
5 years ago (2015-12-09 12:11:21 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
5fb6ad9165c1143a84c87fd213623cf36a5ee013 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698