Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1515503002: Oilpan: fix build after r363998. (Closed)

Created:
5 years ago by sof
Modified:
5 years ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Oilpan: fix build after r363998. The struct contains a raw pointer to an Oilpan heap object (Scrollbar*), which is not allowed without either accounting for its safety (or by having it be traced.) But as the struct is unused, just remove it. R=haraken BUG=560418 NOTRY=true Committed: https://crrev.com/cde7bac5d0f97e78ada01739236c6b6e0f2d2f2b Cr-Commit-Position: refs/heads/master@{#364015}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -7 lines) Patch
M third_party/WebKit/Source/core/paint/PaintInvalidationCapableScrollableArea.cpp View 1 chunk +0 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
sof
5 years ago (2015-12-09 08:38:07 UTC) #1
haraken
LGTM
5 years ago (2015-12-09 08:39:29 UTC) #2
peria
r363998 is already reverted https://chromium.googlesource.com/chromium/src/+/ed0577e5a8952de3976d6b18fa0ed39fe2a0e418#
5 years ago (2015-12-09 08:41:44 UTC) #3
sof
On 2015/12/09 08:41:44, peria wrote: > r363998 is already reverted > https://chromium.googlesource.com/chromium/src/+/ed0577e5a8952de3976d6b18fa0ed39fe2a0e418 But relanded in ...
5 years ago (2015-12-09 08:42:57 UTC) #4
peria
On 2015/12/09 08:42:57, sof wrote: > On 2015/12/09 08:41:44, peria wrote: > > r363998 is ...
5 years ago (2015-12-09 08:44:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515503002/1
5 years ago (2015-12-09 08:47:12 UTC) #8
sof
On 2015/12/09 08:44:44, peria wrote: > On 2015/12/09 08:42:57, sof wrote: > > On 2015/12/09 ...
5 years ago (2015-12-09 08:48:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-09 08:56:40 UTC) #11
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/cde7bac5d0f97e78ada01739236c6b6e0f2d2f2b Cr-Commit-Position: refs/heads/master@{#364015}
5 years ago (2015-12-09 08:57:27 UTC) #13
Xianzhu
5 years ago (2015-12-11 00:51:54 UTC) #14
Message was sent while issue was closed.
Thanks for fixing this. Turned out I forgot to upload the latest patch set (with
the unused struct removed) before landing the original patch.

Powered by Google App Engine
This is Rietveld 408576698