Chromium Code Reviews
|
|
Chromium Code Reviews|
Created:
5 years ago by sof Modified:
5 years ago Reviewers:
oilpan-reviews, haraken CC:
chromium-reviews, blink-reviews, dshwang, slimming-paint-reviews_chromium.org, blink-reviews-paint_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionOilpan: fix build after r363998.
The struct contains a raw pointer to an Oilpan heap object (Scrollbar*),
which is not allowed without either accounting for its safety (or
by having it be traced.)
But as the struct is unused, just remove it.
R=haraken
BUG=560418
NOTRY=true
Committed: https://crrev.com/cde7bac5d0f97e78ada01739236c6b6e0f2d2f2b
Cr-Commit-Position: refs/heads/master@{#364015}
Patch Set 1 #
Created: 5 years ago
Messages
Total messages: 14 (4 generated)
LGTM
r363998 is already reverted https://chromium.googlesource.com/chromium/src/+/ed0577e5a8952de3976d6b18fa0e...
On 2015/12/09 08:41:44, peria wrote: > r363998 is already reverted > https://chromium.googlesource.com/chromium/src/+/ed0577e5a8952de3976d6b18fa0e... But relanded in https://crrev.com/364006
Description was changed from ========== Oilpan: fix build after r363998. The struct contains a raw pointer to an Oilpan heap object (Scrollbar*), which is not allowed without either accounting for its safety (or by having it be traced.) But as the struct is unused, just remove it. TBR=oilpan-reviews BUG=560418 NOTRY=true ========== to ========== Oilpan: fix build after r363998. The struct contains a raw pointer to an Oilpan heap object (Scrollbar*), which is not allowed without either accounting for its safety (or by having it be traced.) But as the struct is unused, just remove it. R=haraken BUG=560418 NOTRY=true ==========
On 2015/12/09 08:42:57, sof wrote: > On 2015/12/09 08:41:44, peria wrote: > > r363998 is already reverted > > > https://chromium.googlesource.com/chromium/src/+/ed0577e5a8952de3976d6b18fa0e... > > But relanded in https://crrev.com/364006 Oops, I did not notice it. I'm sorry being confusing.
The CQ bit was checked by sigbjornf@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515503002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515503002/1
On 2015/12/09 08:44:44, peria wrote: > On 2015/12/09 08:42:57, sof wrote: > > On 2015/12/09 08:41:44, peria wrote: > > > r363998 is already reverted > > > > > > https://chromium.googlesource.com/chromium/src/+/ed0577e5a8952de3976d6b18fa0e... > > > > But relanded in https://crrev.com/364006 > > Oops, I did not notice it. > I'm sorry being confusing. It wasn't helped by mentioning r363998 in the commit message, but it'll all cycle back to green now hopefully (without needing any reverts.)
Message was sent while issue was closed.
Description was changed from ========== Oilpan: fix build after r363998. The struct contains a raw pointer to an Oilpan heap object (Scrollbar*), which is not allowed without either accounting for its safety (or by having it be traced.) But as the struct is unused, just remove it. R=haraken BUG=560418 NOTRY=true ========== to ========== Oilpan: fix build after r363998. The struct contains a raw pointer to an Oilpan heap object (Scrollbar*), which is not allowed without either accounting for its safety (or by having it be traced.) But as the struct is unused, just remove it. R=haraken BUG=560418 NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Oilpan: fix build after r363998. The struct contains a raw pointer to an Oilpan heap object (Scrollbar*), which is not allowed without either accounting for its safety (or by having it be traced.) But as the struct is unused, just remove it. R=haraken BUG=560418 NOTRY=true ========== to ========== Oilpan: fix build after r363998. The struct contains a raw pointer to an Oilpan heap object (Scrollbar*), which is not allowed without either accounting for its safety (or by having it be traced.) But as the struct is unused, just remove it. R=haraken BUG=560418 NOTRY=true Committed: https://crrev.com/cde7bac5d0f97e78ada01739236c6b6e0f2d2f2b Cr-Commit-Position: refs/heads/master@{#364015} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/cde7bac5d0f97e78ada01739236c6b6e0f2d2f2b Cr-Commit-Position: refs/heads/master@{#364015}
Message was sent while issue was closed.
Thanks for fixing this. Turned out I forgot to upload the latest patch set (with the unused struct removed) before landing the original patch. |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
