Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(654)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1515473004: Disable --harmony-object-observe (Closed)

Created:
5 years ago by adamk
Modified:
5 years ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, Michael Hablich
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable --harmony-object-observe BUG=chromium:552100 LOG=y CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel Committed: https://crrev.com/ebdd90142b7de7696979c27f2286128dfad7c259 Cr-Commit-Position: refs/heads/master@{#32815}

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515473004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515473004/1
5 years ago (2015-12-09 20:15:01 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11253)
5 years ago (2015-12-09 20:50:01 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515473004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515473004/20001
5 years ago (2015-12-09 23:36:06 UTC) #6
adamk
5 years ago (2015-12-10 00:03:17 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux_arm_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux_arm_rel/builds/11260)
5 years ago (2015-12-10 00:04:58 UTC) #10
rossberg
lgtm
5 years ago (2015-12-11 15:15:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515473004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515473004/20001
5 years ago (2015-12-11 18:43:05 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-11 21:09:42 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-11 21:10:39 UTC) #16
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/ebdd90142b7de7696979c27f2286128dfad7c259
Cr-Commit-Position: refs/heads/master@{#32815}

Powered by Google App Engine
This is Rietveld 408576698