Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 1515473003: [cleanup] Drop JSObject::GetOwnPropertyNames(). (Closed)

Created:
5 years ago by Jakob Kummerow
Modified:
5 years ago
Reviewers:
Camillo Bruni
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[cleanup] Drop JSObject::GetOwnPropertyNames(). Can be replaced by KeyAccumulator + CollectOwnPropertyNames(). Committed: https://crrev.com/65eef3834907e82ca87ecc863ff0e8face94246d Cr-Commit-Position: refs/heads/master@{#32719}

Patch Set 1 #

Patch Set 2 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -64 lines) Patch
M src/objects.h View 1 3 chunks +3 lines, -7 lines 0 comments Download
M src/objects.cc View 1 3 chunks +9 lines, -57 lines 0 comments Download
M src/property-details.h View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Jakob Kummerow
5 years ago (2015-12-09 12:25:59 UTC) #2
Camillo Bruni
lgtm
5 years ago (2015-12-09 12:42:30 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515473003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515473003/20001
5 years ago (2015-12-09 16:21:30 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years ago (2015-12-09 16:59:36 UTC) #7
commit-bot: I haz the power
5 years ago (2015-12-09 17:03:14 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/65eef3834907e82ca87ecc863ff0e8face94246d
Cr-Commit-Position: refs/heads/master@{#32719}

Powered by Google App Engine
This is Rietveld 408576698