media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc - Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Speculative workaround fix for win8_chromium_ng compile error. Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « media/cast/logging/receiver_time_offset_estimator_impl.cc ('k') | media/cast/logging/simple_event_subscriber_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc

diff --git a/media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc b/media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc

index 73ddd623dc90f9dfdeee9d3f6c4da815f0a736d4..02d8b4c401487f7858f586817229c86ac795edaa 100644

--- a/media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc

+++ b/media/cast/logging/receiver_time_offset_estimator_impl_unittest.cc

@@ -62,7 +62,7 @@ TEST_F(ReceiverTimeOffsetEstimatorImplTest, EstimateOffset) {

EXPECT_FALSE(estimator_.GetReceiverOffsetBounds(&lower_bound, &upper_bound));

- RtpTimestamp rtp_timestamp = 0;

+ const RtpTimeTicks rtp_timestamp;

uint32_t frame_id = 0;

AdvanceClocks(base::TimeDelta::FromMilliseconds(20));

@@ -145,7 +145,7 @@ TEST_F(ReceiverTimeOffsetEstimatorImplTest, EventCArrivesBeforeEventB) {

EXPECT_FALSE(estimator_.GetReceiverOffsetBounds(&lower_bound, &upper_bound));

- RtpTimestamp rtp_timestamp = 0;

+ const RtpTimeTicks rtp_timestamp;

uint32_t frame_id = 0;

AdvanceClocks(base::TimeDelta::FromMilliseconds(20));

@@ -227,11 +227,13 @@ TEST_F(ReceiverTimeOffsetEstimatorImplTest, MultipleIterations) {

base::TimeDelta lower_bound;

base::TimeDelta upper_bound;

- RtpTimestamp rtp_timestamp_a = 0;

+ const RtpTimeTicks rtp_timestamp_a;

int frame_id_a = 0;

- RtpTimestamp rtp_timestamp_b = 90;

+ const RtpTimeTicks rtp_timestamp_b =

+ rtp_timestamp_a + RtpTimeDelta::FromTicks(90);

int frame_id_b = 1;

- RtpTimestamp rtp_timestamp_c = 180;

+ const RtpTimeTicks rtp_timestamp_c =

+ rtp_timestamp_b + RtpTimeDelta::FromTicks(90);

int frame_id_c = 2;

// Frame 1 times: [20, 30+100, 60]