Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1001)

Unified Diff: media/cast/logging/log_deserializer.cc

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Speculative workaround fix for win8_chromium_ng compile error. Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/cast/logging/log_deserializer.h ('k') | media/cast/logging/log_serializer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/cast/logging/log_deserializer.cc
diff --git a/media/cast/logging/log_deserializer.cc b/media/cast/logging/log_deserializer.cc
index 75095aeb25cde25927c4a05c0a7beba604fc581a..3a5810632989af7892a137b004cfb61c3560d563 100644
--- a/media/cast/logging/log_deserializer.cc
+++ b/media/cast/logging/log_deserializer.cc
@@ -14,7 +14,8 @@
using media::cast::FrameEventMap;
using media::cast::PacketEventMap;
-using media::cast::RtpTimestamp;
+using media::cast::RtpTimeDelta;
+using media::cast::RtpTimeTicks;
using media::cast::proto::AggregatedFrameEvent;
using media::cast::proto::AggregatedPacketEvent;
using media::cast::proto::BasePacketEvent;
@@ -73,7 +74,7 @@ bool PopulateDeserializedLog(base::BigEndianReader* reader,
PacketEventMap packet_event_map;
int num_frame_events = log->metadata.num_frame_events();
- RtpTimestamp relative_rtp_timestamp = 0;
+ RtpTimeTicks relative_rtp_timestamp;
uint16_t proto_size = 0;
for (int i = 0; i < num_frame_events; i++) {
if (!reader->ReadU16(&proto_size))
@@ -88,15 +89,15 @@ bool PopulateDeserializedLog(base::BigEndianReader* reader,
// During serialization the RTP timestamp in proto is relative to previous
// frame.
// Adjust RTP timestamp back to value relative to first RTP timestamp.
+ relative_rtp_timestamp +=
+ RtpTimeDelta::FromTicks(frame_event->relative_rtp_timestamp());
frame_event->set_relative_rtp_timestamp(
- frame_event->relative_rtp_timestamp() + relative_rtp_timestamp);
- relative_rtp_timestamp = frame_event->relative_rtp_timestamp();
+ relative_rtp_timestamp.lower_32_bits());
- FrameEventMap::iterator it = frame_event_map.find(
- frame_event->relative_rtp_timestamp());
+ FrameEventMap::iterator it = frame_event_map.find(relative_rtp_timestamp);
if (it == frame_event_map.end()) {
frame_event_map.insert(
- std::make_pair(frame_event->relative_rtp_timestamp(), frame_event));
+ std::make_pair(relative_rtp_timestamp, frame_event));
} else {
// Events for the same frame might have been split into more than one
// proto. Merge them.
@@ -107,7 +108,7 @@ bool PopulateDeserializedLog(base::BigEndianReader* reader,
log->frame_events.swap(frame_event_map);
int num_packet_events = log->metadata.num_packet_events();
- relative_rtp_timestamp = 0;
+ relative_rtp_timestamp = RtpTimeTicks();
for (int i = 0; i < num_packet_events; i++) {
if (!reader->ReadU16(&proto_size))
return false;
@@ -118,15 +119,15 @@ bool PopulateDeserializedLog(base::BigEndianReader* reader,
if (!reader->Skip(proto_size))
return false;
+ relative_rtp_timestamp +=
+ RtpTimeDelta::FromTicks(packet_event->relative_rtp_timestamp());
packet_event->set_relative_rtp_timestamp(
- packet_event->relative_rtp_timestamp() + relative_rtp_timestamp);
- relative_rtp_timestamp = packet_event->relative_rtp_timestamp();
+ relative_rtp_timestamp.lower_32_bits());
- PacketEventMap::iterator it = packet_event_map.find(
- packet_event->relative_rtp_timestamp());
+ PacketEventMap::iterator it = packet_event_map.find(relative_rtp_timestamp);
if (it == packet_event_map.end()) {
packet_event_map.insert(
- std::make_pair(packet_event->relative_rtp_timestamp(), packet_event));
+ std::make_pair(relative_rtp_timestamp, packet_event));
} else {
// Events for the same frame might have been split into more than one
// proto. Merge them.
« no previous file with comments | « media/cast/logging/log_deserializer.h ('k') | media/cast/logging/log_serializer.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698