Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Unified Diff: media/cast/net/rtcp/rtcp_unittest.cc

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/net/rtcp/rtcp_unittest.cc
diff --git a/media/cast/net/rtcp/rtcp_unittest.cc b/media/cast/net/rtcp/rtcp_unittest.cc
index 88b7d45e486196bfd643e27e708f4cb976ca4b1b..8ffd044aeb439ef302a4ed48f69070757d2e1971 100644
--- a/media/cast/net/rtcp/rtcp_unittest.cc
+++ b/media/cast/net/rtcp/rtcp_unittest.cc
@@ -143,13 +143,14 @@ TEST_F(RtcpTest, LipSyncGleanedFromSenderReport) {
// Initially, expect no lip-sync info receiver-side without having first
// received a RTCP packet.
base::TimeTicks reference_time;
- uint32 rtp_timestamp;
+ RtpTimeTicks rtp_timestamp;
ASSERT_FALSE(rtcp_for_receiver_.GetLatestLipSyncTimes(&rtp_timestamp,
&reference_time));
// Send a Sender Report to the receiver.
const base::TimeTicks reference_time_sent = sender_clock_->NowTicks();
- const uint32 rtp_timestamp_sent = 0xbee5;
+ const RtpTimeTicks rtp_timestamp_sent =
+ RtpTimeTicks().Expand(UINT32_C(0xbee5));
rtcp_for_sender_.SendRtcpFromRtpSender(
reference_time_sent, rtp_timestamp_sent, 1, 1);
@@ -193,7 +194,8 @@ TEST_F(RtcpTest, RoundTripTimesDeterminedFromReportPingPong) {
// Sender --> Receiver
base::TimeTicks reference_time_sent = sender_clock_->NowTicks();
- uint32 rtp_timestamp_sent = 0xbee5 + i;
+ const RtpTimeTicks rtp_timestamp_sent =
+ RtpTimeTicks().Expand<uint32_t>(0xbee5) + RtpTimeDelta::FromTicks(i);
rtcp_for_sender_.SendRtcpFromRtpSender(
reference_time_sent, rtp_timestamp_sent, 1, 1);
EXPECT_EQ(expected_rtt_according_to_sender,

Powered by Google App Engine
This is Rietveld 408576698