Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: media/cast/logging/simple_event_subscriber_unittest.cc

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/cast/logging/simple_event_subscriber_unittest.cc
diff --git a/media/cast/logging/simple_event_subscriber_unittest.cc b/media/cast/logging/simple_event_subscriber_unittest.cc
index 92b6c6e707a93429821e6221182411043282be35..2f00e0f1651b65867b626744247ce1247f019fef 100644
--- a/media/cast/logging/simple_event_subscriber_unittest.cc
+++ b/media/cast/logging/simple_event_subscriber_unittest.cc
@@ -44,7 +44,7 @@ TEST_F(SimpleEventSubscriberTest, GetAndResetEvents) {
encode_event->timestamp = testing_clock_->NowTicks();
encode_event->type = FRAME_ENCODED;
encode_event->media_type = AUDIO_EVENT;
- encode_event->rtp_timestamp = 100u;
+ encode_event->rtp_timestamp = RtpTimeTicks().Expand(UINT32_C(100));
Irfan 2015/12/09 21:24:28 Would Expand(100u) work here and elsewhere ?
miu 2015/12/10 00:38:36 Yes, but the interpretation of 100u would be diffe
encode_event->frame_id = 0u;
encode_event->size = 1234;
encode_event->key_frame = true;
@@ -57,7 +57,7 @@ TEST_F(SimpleEventSubscriberTest, GetAndResetEvents) {
playout_event->timestamp = testing_clock_->NowTicks();
playout_event->type = FRAME_PLAYOUT;
playout_event->media_type = AUDIO_EVENT;
- playout_event->rtp_timestamp = 100u;
+ playout_event->rtp_timestamp = RtpTimeTicks().Expand(UINT32_C(100));
playout_event->frame_id = 0u;
playout_event->delay_delta = base::TimeDelta::FromMilliseconds(100);
cast_environment_->logger()->DispatchFrameEvent(playout_event.Pass());
@@ -66,7 +66,7 @@ TEST_F(SimpleEventSubscriberTest, GetAndResetEvents) {
decode_event->timestamp = testing_clock_->NowTicks();
decode_event->type = FRAME_DECODED;
decode_event->media_type = AUDIO_EVENT;
- decode_event->rtp_timestamp = 200u;
+ decode_event->rtp_timestamp = RtpTimeTicks().Expand(UINT32_C(200));
decode_event->frame_id = 0u;
cast_environment_->logger()->DispatchFrameEvent(decode_event.Pass());
@@ -75,7 +75,7 @@ TEST_F(SimpleEventSubscriberTest, GetAndResetEvents) {
receive_event->timestamp = testing_clock_->NowTicks();
receive_event->type = PACKET_RECEIVED;
receive_event->media_type = AUDIO_EVENT;
- receive_event->rtp_timestamp = 200u;
+ receive_event->rtp_timestamp = RtpTimeTicks().Expand(UINT32_C(200));
receive_event->frame_id = 0u;
receive_event->packet_id = 1u;
receive_event->max_packet_id = 5u;
@@ -86,7 +86,7 @@ TEST_F(SimpleEventSubscriberTest, GetAndResetEvents) {
receive_event->timestamp = testing_clock_->NowTicks();
receive_event->type = PACKET_RECEIVED;
receive_event->media_type = VIDEO_EVENT;
- receive_event->rtp_timestamp = 200u;
+ receive_event->rtp_timestamp = RtpTimeTicks().Expand(UINT32_C(200));
receive_event->frame_id = 0u;
receive_event->packet_id = 1u;
receive_event->max_packet_id = 10u;

Powered by Google App Engine
This is Rietveld 408576698