media/cast/logging/logging_defines.h - Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/cast/logging/logging_defines.h

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« media/cast/logging/encoding_event_subscriber_unittest.cc ('K') | « media/cast/logging/log_serializer.cc ('k') | media/cast/logging/logging_defines.cc » ('j') | media/cast/logging/simple_event_subscriber_unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: media/cast/logging/logging_defines.h

diff --git a/media/cast/logging/logging_defines.h b/media/cast/logging/logging_defines.h

index dc295547252f7f8222d9ac2a551dc5773abdde3e..d7201b1d2f6ca8d5aa477f9d32b833ea2f3ec9f8 100644

--- a/media/cast/logging/logging_defines.h

+++ b/media/cast/logging/logging_defines.h

@@ -10,14 +10,13 @@

#include <vector>

#include "base/time/time.h"

+#include "media/cast/common/rtp_time.h"

namespace media {

namespace cast {

static const uint32 kFrameIdUnknown = 0xFFFFFFFF;

-typedef uint32 RtpTimestamp;

enum CastLoggingEvent {

UNKNOWN,

// Sender side frame events.

@@ -52,7 +51,7 @@ struct FrameEvent {

FrameEvent();

~FrameEvent();

- RtpTimestamp rtp_timestamp;

+ RtpTimeTicks rtp_timestamp;

uint32 frame_id;

// Resolution of the frame. Only set for video FRAME_CAPTURE_END events.

@@ -92,7 +91,7 @@ struct PacketEvent {

PacketEvent();

~PacketEvent();

- RtpTimestamp rtp_timestamp;

+ RtpTimeTicks rtp_timestamp;

uint32 frame_id;

uint16 max_packet_id;

uint16 packet_id;