Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: media/cast/net/rtcp/rtcp_utility.h

Issue 1515433002: Replace uses of raw uint32's with a type-checked RtpTimeTicks data type. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MEDIA_CAST_RTCP_RTCP_UTILITY_H_ 5 #ifndef MEDIA_CAST_RTCP_RTCP_UTILITY_H_
6 #define MEDIA_CAST_RTCP_RTCP_UTILITY_H_ 6 #define MEDIA_CAST_RTCP_RTCP_UTILITY_H_
7 7
8 #include "base/big_endian.h" 8 #include "base/big_endian.h"
9 #include "media/cast/logging/logging_defines.h" 9 #include "media/cast/logging/logging_defines.h"
10 #include "media/cast/net/cast_transport_config.h" 10 #include "media/cast/net/cast_transport_config.h"
(...skipping 66 matching lines...) Expand 10 before | Expand all | Expand 10 after
77 bool ParseFeedbackCommon(base::BigEndianReader* reader, 77 bool ParseFeedbackCommon(base::BigEndianReader* reader,
78 const RtcpCommonHeader& header); 78 const RtcpCommonHeader& header);
79 bool ParseExtendedReport(base::BigEndianReader* reader, 79 bool ParseExtendedReport(base::BigEndianReader* reader,
80 const RtcpCommonHeader& header); 80 const RtcpCommonHeader& header);
81 bool ParseExtendedReportReceiverReferenceTimeReport( 81 bool ParseExtendedReportReceiverReferenceTimeReport(
82 base::BigEndianReader* reader, 82 base::BigEndianReader* reader,
83 uint32 remote_ssrc); 83 uint32 remote_ssrc);
84 bool ParseExtendedReportDelaySinceLastReceiverReport( 84 bool ParseExtendedReportDelaySinceLastReceiverReport(
85 base::BigEndianReader* reader); 85 base::BigEndianReader* reader);
86 86
87 uint32 local_ssrc_; 87 const uint32 local_ssrc_;
88 uint32 remote_ssrc_; 88 const uint32 remote_ssrc_;
89 89
90 bool has_sender_report_; 90 bool has_sender_report_;
91 RtcpSenderInfo sender_report_; 91 RtcpSenderInfo sender_report_;
92 92
93 uint32 last_report_; 93 uint32 last_report_;
94 uint32 delay_since_last_report_; 94 uint32 delay_since_last_report_;
95 bool has_last_report_; 95 bool has_last_report_;
96 96
97 // |receiver_log_| is a vector vector, no need for has_*. 97 // |receiver_log_| is a vector vector, no need for has_*.
98 RtcpReceiverLogMessage receiver_log_; 98 RtcpReceiverLogMessage receiver_log_;
99 99
100 bool has_cast_message_; 100 bool has_cast_message_;
101 RtcpCastMessage cast_message_; 101 RtcpCastMessage cast_message_;
102 102
103 bool has_receiver_reference_time_report_; 103 bool has_receiver_reference_time_report_;
104 RtcpReceiverReferenceTimeReport receiver_reference_time_report_; 104 RtcpReceiverReferenceTimeReport receiver_reference_time_report_;
105 105
106 // Tracks recently-parsed RTP timestamps so that the truncated values can be
107 // re-expanded into full-form.
108 RtpTimeTicks last_parsed_sr_rtp_timestamp_;
109 RtpTimeTicks last_parsed_frame_log_rtp_timestamp_;
110
106 DISALLOW_COPY_AND_ASSIGN(RtcpParser); 111 DISALLOW_COPY_AND_ASSIGN(RtcpParser);
107 }; 112 };
108 113
109 // Converts a log event type to an integer value. 114 // Converts a log event type to an integer value.
110 // NOTE: We have only allocated 4 bits to represent the type of event over the 115 // NOTE: We have only allocated 4 bits to represent the type of event over the
111 // wire. Therefore, this function can only return values from 0 to 15. 116 // wire. Therefore, this function can only return values from 0 to 15.
112 uint8 ConvertEventTypeToWireFormat(CastLoggingEvent event); 117 uint8 ConvertEventTypeToWireFormat(CastLoggingEvent event);
113 118
114 // The inverse of |ConvertEventTypeToWireFormat()|. 119 // The inverse of |ConvertEventTypeToWireFormat()|.
115 CastLoggingEvent TranslateToLogEventFromWireFormat(uint8 event); 120 CastLoggingEvent TranslateToLogEventFromWireFormat(uint8 event);
(...skipping 11 matching lines...) Expand all
127 132
128 // Maps an NTP timestamp, comprised of two components, to a base::TimeTicks 133 // Maps an NTP timestamp, comprised of two components, to a base::TimeTicks
129 // value. 134 // value.
130 base::TimeTicks ConvertNtpToTimeTicks(uint32_t ntp_seconds, 135 base::TimeTicks ConvertNtpToTimeTicks(uint32_t ntp_seconds,
131 uint32_t ntp_fractions); 136 uint32_t ntp_fractions);
132 137
133 } // namespace cast 138 } // namespace cast
134 } // namespace media 139 } // namespace media
135 140
136 #endif // MEDIA_CAST_RTCP_RTCP_UTILITY_H_ 141 #endif // MEDIA_CAST_RTCP_RTCP_UTILITY_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698