Issue 151543005: Cleanup: Update TestObject.h to Chromium style.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151543005: Cleanup: Update TestObject.h to Chromium style. (Closed)

Created:
6 years, 10 months ago by tfarina

Modified:
6 years, 10 months ago

Reviewers:
jochen (gone - plz use gerrit)

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam, jochen+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Cleanup: Update TestObject.h to Chromium style. - rename to test_object.h - put in content namespace - CamelCase for function names. minimal changes for now. BUG=342118 TEST=None R=jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=250857

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -50 lines)			Patch
M	content/content_shell.gypi	View		2 chunks	+1 line, -1 line	0 comments	Download
M	content/shell/tools/plugin/PluginObject.cpp	View		4 chunks	+5 lines, -4 lines	0 comments	Download
D	content/shell/tools/plugin/TestObject.h	View		1 chunk	+0 lines, -34 lines	0 comments	Download
M	content/shell/tools/plugin/TestObject.cpp	View	1	6 chunks	+15 lines, -9 lines	0 comments	Download
A +	content/shell/tools/plugin/test_object.h	View		1 chunk	+11 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

tfarina

starting with a minimal cleanup possible. I have limited time :/

6 years, 10 months ago (2014-02-12 00:13:23 UTC) #1

jochen (gone - plz use gerrit)

lgtm btw, I think it's a better use of time to update the test runner ...

6 years, 10 months ago (2014-02-12 09:40:53 UTC) #2

tfarina

6 years, 10 months ago (2014-02-13 00:10:14 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r250857 (presubmit successful).