Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1515413002: Transfer context deadline to AEContext. (Closed)

Created:
5 years ago by Vadim Sh.
Modified:
5 years ago
Reviewers:
iannucci
CC:
chromium-reviews, infra-reviews+luci-gae_chromium.org
Base URL:
https://github.com/luci/gae.git@master
Target Ref:
refs/heads/master
Project:
luci-gae
Visibility:
Public.

Description

Transfer context deadline to AEContext. It's needed to be able to tweak default RPC timeout (5 sec), in particularly when using urlfetch service. R=iannucci@chromium.org BUG= Committed: https://github.com/luci/gae/commit/c8ceb29058d5632b962bfdb96c34f59fb8a6ec98

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M impl/prod/context.go View 2 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Vadim Sh.
ptal at least it fixed luci-cron stuff
5 years ago (2015-12-12 02:24:25 UTC) #1
iannucci
lgtm
5 years ago (2015-12-12 02:25:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515413002/1
5 years ago (2015-12-12 02:25:56 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-12 02:28:41 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://github.com/luci/gae/commit/c8ceb29058d5632b962bfdb96c34f59fb8a6ec98

Powered by Google App Engine
This is Rietveld 408576698