Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1515323002:
MediaRecorder test: disable flaky time stamp checks. (Closed)
|
Created:
5 years ago by cpaulin (no longer in chrome) Modified:
5 years ago CC:
chromium-reviews, darin-cc_chromium.org, jam, feature-media-reviews_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionMediaRecorder test: disable flaky time stamp checks.
MediaRecorder testing start(time_slice): disable the flaky
time stamps delta calculations because they can be slightly
off and cause some bots to fail. The root cause is the time
stamp delta was supposed to be 100ms but it came out as
99.99999999999955ms which failed (sic.). The corrective
action is to remove that time stamp check.
Removal of this check is fine because the checks pertains
to a performance measurement, which is not necessary in a
content browser test.
The flakiness had only been found on MAC bots so far.
BUG=568913
mcasas@ PTAL
avi@ Owners RS
Committed: https://crrev.com/229dc6e6054036590deace42242aadf3991cd019
Cr-Commit-Position: refs/heads/master@{#364859}
Patch Set 1 #
Messages
Total messages: 19 (12 generated)
Description was changed from ========== Emergency fix for crbug.com/568913 to disable time stamp checks BUG= 568913 ========== to ========== Emergency fix for crbug.com/568913 to disable time stamp checks BUG= 568913 ==========
cpaulin@chromium.org changed reviewers: + avi@chromium.org, mcasas@chromium.org, tommi@chromium.org
Description was changed from ========== Emergency fix for crbug.com/568913 to disable time stamp checks BUG= 568913 ========== to ========== MediaRecorder test: disable flaky time stamp checks. BUG=568913 MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). mcasas@ PTAL avi@ Owners RS ==========
cpaulin@chromium.org changed reviewers: - tommi@chromium.org
Description was changed from ========== MediaRecorder test: disable flaky time stamp checks. BUG=568913 MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). mcasas@ PTAL avi@ Owners RS ========== to ========== MediaRecorder test: disable flaky time stamp checks. BUG=568913 MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). The corrective action is to remove that time stamp check mcasas@ PTAL avi@ Owners RS ==========
mcasas@ PTAL avi@ Owners RS
Description was changed from ========== MediaRecorder test: disable flaky time stamp checks. BUG=568913 MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). The corrective action is to remove that time stamp check mcasas@ PTAL avi@ Owners RS ========== to ========== MediaRecorder test: disable flaky time stamp checks. MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). The corrective action is to remove that time stamp check BUG=568913 mcasas@ PTAL avi@ Owners RS ==========
Description was changed from ========== MediaRecorder test: disable flaky time stamp checks. MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). The corrective action is to remove that time stamp check BUG=568913 mcasas@ PTAL avi@ Owners RS ========== to ========== MediaRecorder test: disable flaky time stamp checks. MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). The corrective action is to remove that time stamp check. Removal of this check is fine because the checks pertains to a performance measurement, which is not necessary in a content browser test. The flakiness had only been found on MAC bots so far. BUG=568913 mcasas@ PTAL avi@ Owners RS ==========
lgtm
The CQ bit was checked by cpaulin@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515323002/1
lgtm
The CQ bit was unchecked by cpaulin@chromium.org
The CQ bit was checked by cpaulin@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515323002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515323002/1
Message was sent while issue was closed.
Description was changed from ========== MediaRecorder test: disable flaky time stamp checks. MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). The corrective action is to remove that time stamp check. Removal of this check is fine because the checks pertains to a performance measurement, which is not necessary in a content browser test. The flakiness had only been found on MAC bots so far. BUG=568913 mcasas@ PTAL avi@ Owners RS ========== to ========== MediaRecorder test: disable flaky time stamp checks. MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). The corrective action is to remove that time stamp check. Removal of this check is fine because the checks pertains to a performance measurement, which is not necessary in a content browser test. The flakiness had only been found on MAC bots so far. BUG=568913 mcasas@ PTAL avi@ Owners RS ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== MediaRecorder test: disable flaky time stamp checks. MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). The corrective action is to remove that time stamp check. Removal of this check is fine because the checks pertains to a performance measurement, which is not necessary in a content browser test. The flakiness had only been found on MAC bots so far. BUG=568913 mcasas@ PTAL avi@ Owners RS ========== to ========== MediaRecorder test: disable flaky time stamp checks. MediaRecorder testing start(time_slice): disable the flaky time stamps delta calculations because they can be slightly off and cause some bots to fail. The root cause is the time stamp delta was supposed to be 100ms but it came out as 99.99999999999955ms which failed (sic.). The corrective action is to remove that time stamp check. Removal of this check is fine because the checks pertains to a performance measurement, which is not necessary in a content browser test. The flakiness had only been found on MAC bots so far. BUG=568913 mcasas@ PTAL avi@ Owners RS Committed: https://crrev.com/229dc6e6054036590deace42242aadf3991cd019 Cr-Commit-Position: refs/heads/master@{#364859} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/229dc6e6054036590deace42242aadf3991cd019 Cr-Commit-Position: refs/heads/master@{#364859} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
