Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1515303003:
Blink MediaRecorder: flipping flag to stable (Closed)
DescriptionBlink MediaRecorder: flipping flag to stable
After Intent-To-Ship got LGTMs, see [1]
[1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5AgAJ
BUG=262211
TBR=philipj@opera.com (RS for the LayoutTest expected.txt update).
Committed: https://crrev.com/6c0b9dc0d2fe634ac1e9f82e6d1c9300f5f08133
Cr-Commit-Position: refs/heads/master@{#364912}
Patch Set 1 #Patch Set 2 : updated virtual/stable/webexposed/global-interface-listing.html #
Messages
Total messages: 24 (14 generated)
mcasas@chromium.org changed reviewers: + esprehn@chromium.org
esprehn@ Owners RS
lgtm, Make it so! This is how I feel about this patch: http://i.imgur.com/DtG3nv8.gif
mcasas@chromium.org changed reviewers: + philipj@opera.com
philipj@opera.com: need a RS for the API expected.txt
The CQ bit was checked by esprehn@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from esprehn@chromium.org Link to the patchset: https://codereview.chromium.org/1515303003/#ps20001 (title: "updated virtual/stable/webexposed/global-interface-listing.html")
Description was changed from ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 ========== to ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 TBR=philipj@opera.com (after an offline chat with esprehn@, your CL should not be needed for just a LayoutTest expected update, so let me transfer you here). ==========
Description was changed from ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 TBR=philipj@opera.com (after an offline chat with esprehn@, your CL should not be needed for just a LayoutTest expected update, so let me transfer you here). ========== to ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 TBR=philipj@opera.com (after an offline chat with esprehn@, your RS should not be needed for just a LayoutTest expected update, so let me transfer you here). ==========
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515303003/20001
The CQ bit was unchecked by esprehn@chromium.org
Description was changed from ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 TBR=philipj@opera.com (after an offline chat with esprehn@, your RS should not be needed for just a LayoutTest expected update, so let me transfer you here). ========== to ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 Tee Bee aR=philipj@opera.com (after an offline chat with esprehn@, your RS should not be needed for just a LayoutTest expected update, so let me transfer you here). ==========
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515303003/20001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
Description was changed from ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 Tee Bee aR=philipj@opera.com (after an offline chat with esprehn@, your RS should not be needed for just a LayoutTest expected update, so let me transfer you here). ========== to ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 TBR=philipj@opera.com (RS for the LayoutTest expected.txt update). ==========
The CQ bit was checked by mcasas@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515303003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515303003/20001
Message was sent while issue was closed.
Description was changed from ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 TBR=philipj@opera.com (RS for the LayoutTest expected.txt update). ========== to ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 TBR=philipj@opera.com (RS for the LayoutTest expected.txt update). ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 TBR=philipj@opera.com (RS for the LayoutTest expected.txt update). ========== to ========== Blink MediaRecorder: flipping flag to stable After Intent-To-Ship got LGTMs, see [1] [1] https://groups.google.com/a/chromium.org/d/msg/blink-dev/76HB0BIxk_o/GmUpqM_5... BUG=262211 TBR=philipj@opera.com (RS for the LayoutTest expected.txt update). Committed: https://crrev.com/6c0b9dc0d2fe634ac1e9f82e6d1c9300f5f08133 Cr-Commit-Position: refs/heads/master@{#364912} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/6c0b9dc0d2fe634ac1e9f82e6d1c9300f5f08133 Cr-Commit-Position: refs/heads/master@{#364912}
Message was sent while issue was closed.
On 2015/12/12 02:21:01, mcasas wrote: > mailto:philipj@opera.com: need a RS for the API expected.txt lgtm |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
