Issue 151523007: A64: Move some deoptimization logic into a separate function

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 151523007: A64: Move some deoptimization logic into a separate function (Closed)

Created:
6 years, 10 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 10 months ago

Reviewers:
ulan, Rodolph Perfetta (ARM)

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/a64

Visibility:
Public.

More Reviews

Description

A64: Move some deoptimization logic into a separate function In two follow-up changes, I will add support for the deoptimize-every-n-times flag, and run the now seperated code from all DeoptimizeIf* variants BUG=none R=ulan@chromium.org, rodolph.perfetta@arm.com LOG=n Committed: https://code.google.com/p/v8/source/detail?r=19227

Patch Set 1 #

Total comments: 1

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+21 lines, -5 lines)			Patch
	M	src/a64/lithium-codegen-a64.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
	M	src/a64/lithium-codegen-a64.cc	View		2 chunks	+20 lines, -5 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ulan

lgtm https://codereview.chromium.org/151523007/diff/1/src/a64/lithium-codegen-a64.cc File src/a64/lithium-codegen-a64.cc (right): https://codereview.chromium.org/151523007/diff/1/src/a64/lithium-codegen-a64.cc#newcode977 src/a64/lithium-codegen-a64.cc:977: if (!DeoptimizeHeader(environment)) V8 style nit: either put "return" ...

6 years, 10 months ago (2014-02-10 14:22:46 UTC) #2

jochen (gone - plz use gerrit)

6 years, 10 months ago (2014-02-10 14:25:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r19227 (presubmit successful).

Expand Messages | Collapse Messages