src/utils/SkParsePath.cpp - Issue 1515193002: Fix a crash in SkParsePath::FromSVGString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/utils/SkParsePath.cpp

Issue 1515193002: Fix a crash in SkParsePath::FromSVGString (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Add comment Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/utils/SkParsePath.cpp

diff --git a/src/utils/SkParsePath.cpp b/src/utils/SkParsePath.cpp

index 3fecb46fe60de2af5b551c3885ae2e827342bb0e..3eb9e1ef798e26abfcbe6c87345e75592919a712 100644

--- a/src/utils/SkParsePath.cpp

+++ b/src/utils/SkParsePath.cpp

@@ -77,6 +77,10 @@ bool SkParsePath::FromSVGString(const char data[], SkPath* result) {

char previousOp = '\0';

bool relative = false;

for (;;) {

+ if (!data) {

+ // Truncated data

+ return false;

+ }

data = skip_ws(data);

if (data[0] == '\0') {

break;

« no previous file with comments | « no previous file | tests/ParsePathTest.cpp » ('j') | no next file with comments »