Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: components/gcm_driver/gcm_stats_recorder_impl.cc

Issue 1515153003: Enable chrome://gcm-internals on Android (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/gcm_driver/gcm_stats_recorder_impl.cc
diff --git a/components/gcm_driver/gcm_stats_recorder_impl.cc b/components/gcm_driver/gcm_stats_recorder_impl.cc
index e1731c707602ff7b9bdc57846152dfe83f9edb5a..9e345669624b6516bcc36df367cf0b00c4b23302 100644
--- a/components/gcm_driver/gcm_stats_recorder_impl.cc
+++ b/components/gcm_driver/gcm_stats_recorder_impl.cc
@@ -153,10 +153,6 @@ GCMStatsRecorderImpl::GCMStatsRecorderImpl()
GCMStatsRecorderImpl::~GCMStatsRecorderImpl() {
}
-void GCMStatsRecorderImpl::SetRecording(bool recording) {
- is_recording_ = recording;
-}
-
void GCMStatsRecorderImpl::SetDelegate(Delegate* delegate) {
delegate_ = delegate;
}
@@ -290,7 +286,7 @@ void GCMStatsRecorderImpl::RecordRegistration(
void GCMStatsRecorderImpl::RecordRegistrationSent(
const std::string& app_id,
const std::string& sender_ids) {
- UMA_HISTOGRAM_COUNTS("GCM.RegistrationRequest", 1);
+ UMA_HISTOGRAM_BOOLEAN("GCM.RegistrationRequest", true);
if (!is_recording_)
return;
RecordRegistration(app_id, sender_ids,
@@ -326,7 +322,7 @@ void GCMStatsRecorderImpl::RecordRegistrationRetryDelayed(
void GCMStatsRecorderImpl::RecordUnregistrationSent(
const std::string& app_id, const std::string& source) {
- UMA_HISTOGRAM_COUNTS("GCM.UnregistrationRequest", 1);
+ UMA_HISTOGRAM_BOOLEAN("GCM.UnregistrationRequest", true);
if (!is_recording_)
return;
RecordRegistration(app_id, source, "Unregistration request sent",
@@ -385,7 +381,7 @@ void GCMStatsRecorderImpl::RecordDataMessageReceived(
bool to_registered_app,
ReceivedMessageType message_type) {
if (to_registered_app)
- UMA_HISTOGRAM_COUNTS("GCM.DataMessageReceived", 1);
+ UMA_HISTOGRAM_BOOLEAN("GCM.DataMessageReceived", true);
base::TimeTicks new_timestamp = base::TimeTicks::Now();
if (last_received_data_message_burst_start_time_.is_null()) {
@@ -442,25 +438,25 @@ void GCMStatsRecorderImpl::RecordDataMessageReceived(
}
void GCMStatsRecorderImpl::CollectActivities(
- RecordedActivities* recorder_activities) const {
- recorder_activities->checkin_activities.insert(
- recorder_activities->checkin_activities.begin(),
+ RecordedActivities* recorded_activities) const {
+ recorded_activities->checkin_activities.insert(
+ recorded_activities->checkin_activities.begin(),
checkin_activities_.begin(),
checkin_activities_.end());
- recorder_activities->connection_activities.insert(
- recorder_activities->connection_activities.begin(),
+ recorded_activities->connection_activities.insert(
+ recorded_activities->connection_activities.begin(),
connection_activities_.begin(),
connection_activities_.end());
- recorder_activities->registration_activities.insert(
- recorder_activities->registration_activities.begin(),
+ recorded_activities->registration_activities.insert(
+ recorded_activities->registration_activities.begin(),
registration_activities_.begin(),
registration_activities_.end());
- recorder_activities->receiving_activities.insert(
- recorder_activities->receiving_activities.begin(),
+ recorded_activities->receiving_activities.insert(
+ recorded_activities->receiving_activities.begin(),
receiving_activities_.begin(),
receiving_activities_.end());
- recorder_activities->sending_activities.insert(
- recorder_activities->sending_activities.begin(),
+ recorded_activities->sending_activities.insert(
+ recorded_activities->sending_activities.begin(),
sending_activities_.begin(),
sending_activities_.end());
}

Powered by Google App Engine
This is Rietveld 408576698