Enable chrome://gcm-internals on Android

components/gcm_driver/gcm_stats_recorder_android.h

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef COMPONENTS_GCM_DRIVER_GCM_STATS_RECORDER_ANDROID_H_
+#define COMPONENTS_GCM_DRIVER_GCM_STATS_RECORDER_ANDROID_H_
+
+#include <deque>
+#include <string>
+
+#include "base/macros.h"
+#include "components/gcm_driver/gcm_activity.h"
+
+namespace gcm {
+
+class RecordedActivities;
+
+// Stats recorder for Android, used for recording stats and activities on the
+// GCM Driver level for debugging purposes. Based on the GCMStatsRecorder, as
+// defined in the GCM Engine, which does not exist on Android.
+class GCMStatsRecorderAndroid {
+ public:
+  // A delegate interface that allows the GCMStatsRecorderAndroid instance to
+  // interact with its container.
+  class Delegate {
+   public:
+    // Called when the GCMStatsRecorderAndroid is recording activities and a new
+    // activity has just been recorded.
+    virtual void OnActivityRecorded() = 0;
+  };
+
+  explicit GCMStatsRecorderAndroid(Delegate* delegate);
+  ~GCMStatsRecorderAndroid();

[jianli, 2015/12/18 00:10:00]

nit: add virtual

[Peter Beverloo, 2015/12/18 17:19:16]

Why? This class neither has a virtual base class, nor has derived classes.

+
+  bool is_recording() const { return is_recording_; }

[jianli, 2015/12/18 00:09:59]

nit: move this getter and the setter below after method declarations.

[Peter Beverloo, 2015/12/18 17:19:16]

Done. (Also for GCMStatsRecorderImpl, + Nicolas' SetRecording comment.)

+  void set_is_recording(bool recording) { is_recording_ = recording; }
+
+  void Clear();

[jianli, 2015/12/18 00:09:59]

nit: comment this

[Peter Beverloo, 2015/12/18 17:19:17]

Done.

+
+  // Collect all recorded activities into |*recorder_activities|.

[jianli, 2015/12/18 00:10:00]

nit: Collect => Collects

[Peter Beverloo, 2015/12/18 17:19:16]

Done.

+  void CollectActivities(RecordedActivities* recorder_activities) const;

[jianli, 2015/12/18 00:09:59]

recorder => recorded

[Peter Beverloo, 2015/12/18 17:19:16]

Done. (Also for GCMStatsRecorderImpl.)

+
+  // Records that a registration for |app_id| has been sent.
+  void RecordRegistrationSent(const std::string& app_id);
+
+  // Records that the registration sent for |app_id| has received a response.
+  // |success| indicates whether the registration was successful.
+  void RecordRegistrationResponse(const std::string& app_id, bool success);
+
+  // Records that an unregistration for |app_id| has been sent.
+  void RecordUnregistrationSent(const std::string& app_id);
+
+  // Records that the unregistration sent for |app_id| has received a response.
+  // |success| indicates whether the unregistration was successful.
+  void RecordUnregistrationResponse(const std::string& app_id, bool success);
+
+  // Records that a data message has been received for |app_id|.
+  void RecordDataMessageReceived(const std::string& app_id,
+                                 int message_byte_size);
+
+ private:
+  void RecordRegistration(const std::string& app_id,
+                          const std::string& event,
+                          const std::string& details);
+
+  // Delegate made available by the container. May be a nullptr.
+  Delegate* delegate_;
+
+  // Toggle determining whether the recorder is recording.
+  bool is_recording_ = false;
+
+  // Recorded registration activities (which includes unregistrations).
+  std::deque<RegistrationActivity> registration_activities_;
+
+  // Recorded received message activities.
+  std::deque<ReceivingActivity> receiving_activities_;
+
+  DISALLOW_COPY_AND_ASSIGN(GCMStatsRecorderAndroid);
+};
+
+}  // namespace gcm
+
+#endif  // COMPONENTS_GCM_DRIVER_GCM_STATS_RECORDER_ANDROID_H_