Enable chrome://gcm-internals on Android

components/gcm_driver/gcm_stats_recorder_android.cc

+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "components/gcm_driver/gcm_stats_recorder_android.h"
+
+namespace gcm {
+
+const size_t MAX_LOGGED_ACTIVITY_COUNT = 100;
+
+const char kSuccess[] = "SUCCESS";

[Alexei Svitkine (slow), 2015/12/21 15:43:54]

Nit: Add an anonymous namespace around these.

[Peter Beverloo, 2015/12/21 16:18:58]

I have added an anonymous namespace per your request, but there is no need for
one and whether or not it should be there seems to be depending on the reviewer.

I've asked the CXX team for guidance here:
https://groups.google.com/a/chromium.org/forum/#!topic/cxx/VzzBZW4bwh4

+const char kUnknownError[] = "UNKNOWN_ERROR";
+
+GCMStatsRecorderAndroid::GCMStatsRecorderAndroid(Delegate* delegate)
+    : delegate_(delegate) {}
+
+GCMStatsRecorderAndroid::~GCMStatsRecorderAndroid() {}
+
+void GCMStatsRecorderAndroid::Clear() {
+  registration_activities_.clear();
+  receiving_activities_.clear();
+}
+
+void GCMStatsRecorderAndroid::CollectActivities(
+    RecordedActivities* recorded_activities) const {
+  DCHECK(recorded_activities);
+
+  recorded_activities->registration_activities.insert(
+      recorded_activities->registration_activities.begin(),
+      registration_activities_.begin(),
+      registration_activities_.end());
+  recorded_activities->receiving_activities.insert(
+      recorded_activities->receiving_activities.begin(),
+      receiving_activities_.begin(),
+      receiving_activities_.end());
+}
+
+void GCMStatsRecorderAndroid::RecordRegistrationSent(
+    const std::string& app_id) {
+  if (!is_recording_)
+    return;
+
+  RecordRegistration(app_id, "Registration request sent", "" /* details */);
+}
+
+void GCMStatsRecorderAndroid::RecordRegistrationResponse(
+    const std::string& app_id,
+    bool success) {
+  if (!is_recording_)
+    return;
+
+  RecordRegistration(
+      app_id, "Registration response received", success ? kSuccess
+                                                        : kUnknownError);
+}
+
+void GCMStatsRecorderAndroid::RecordUnregistrationSent(
+    const std::string& app_id) {
+  if (!is_recording_)
+    return;
+
+  RecordRegistration(app_id, "Unregistration request sent", "" /* details */);
+}
+
+void GCMStatsRecorderAndroid::RecordUnregistrationResponse(
+    const std::string& app_id,
+    bool success) {
+  if (!is_recording_)
+    return;
+
+  RecordRegistration(
+      app_id, "Unregistration response received", success ? kSuccess
+                                                          : kUnknownError);
+}
+
+void GCMStatsRecorderAndroid::RecordRegistration(const std::string& app_id,
+                                                 const std::string& event,
+                                                 const std::string& details) {
+  RegistrationActivity activity;
+  activity.app_id = app_id;
+  activity.event = event;
+  activity.details = details;
+
+  // TODO(peter): Include the |source| (sender id(s)) of the registrations.
+
+  registration_activities_.push_front(activity);
+  if (registration_activities_.size() > MAX_LOGGED_ACTIVITY_COUNT)
+    registration_activities_.pop_back();
+
+  if (delegate_)
+    delegate_->OnActivityRecorded();
+}
+
+void GCMStatsRecorderAndroid::RecordDataMessageReceived(
+    const std::string& app_id,
+    int message_byte_size) {
+  if (!is_recording_)
+    return;
+
+  ReceivingActivity activity;
+  activity.app_id = app_id;
+  activity.message_byte_size = message_byte_size;
+  activity.event = "Data msg received";
+
+  receiving_activities_.push_front(activity);
+  if (receiving_activities_.size() > MAX_LOGGED_ACTIVITY_COUNT)
+    receiving_activities_.pop_back();
+
+  if (delegate_)
+    delegate_->OnActivityRecorded();
+}
+
+}  // namespace gcm