Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1515133002: [proxies] Support proxies in JSON.parse and JSON.stringify. (Closed)

Created:
5 years ago by neis
Modified:
5 years ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, adamk
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[proxies] Support proxies in JSON.parse and JSON.stringify. This CL tries to correctly support the following: - stringifying a proxy, - stringifying with a proxy as replacer (callable or arraylike), - stringifying with a replacer that returns a proxy, - parsing with a callable proxy as reviver, - parsing with a reviver that inserts proxies into the object, - and whatever else you can imagine. This also fixes some bugs observable without proxies. BUG=v8:3139, v8:1543 LOG=n Committed: https://crrev.com/1596b015ff1ac5df72637e8423ab1467a137c8c6 Cr-Commit-Position: refs/heads/master@{#32843}

Patch Set 1 #

Patch Set 2 : Blacklist ignition tests. #

Patch Set 3 : Try that again. #

Patch Set 4 : Rebase #

Patch Set 5 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+504 lines, -88 lines) Patch
M src/bootstrapper.cc View 1 2 3 4 6 chunks +74 lines, -31 lines 0 comments Download
M src/contexts.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/js/json.js View 7 chunks +36 lines, -34 lines 0 comments Download
M test/mjsunit/harmony/proxies-json.js View 10 chunks +354 lines, -22 lines 0 comments Download
M test/mjsunit/json.js View 1 chunk +29 lines, -0 lines 0 comments Download
M test/mjsunit/mjsunit.status View 1 2 3 4 7 chunks +7 lines, -1 line 0 comments Download
M test/test262/test262.status View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
neis
PTAL
5 years ago (2015-12-11 14:31:11 UTC) #3
Yang
On 2015/12/11 14:31:11, neis wrote: > PTAL lgtm.
5 years ago (2015-12-14 13:50:18 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515133002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515133002/80001
5 years ago (2015-12-14 14:25:13 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years ago (2015-12-14 15:11:59 UTC) #11
commit-bot: I haz the power
5 years ago (2015-12-14 15:12:20 UTC) #13
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/1596b015ff1ac5df72637e8423ab1467a137c8c6
Cr-Commit-Position: refs/heads/master@{#32843}

Powered by Google App Engine
This is Rietveld 408576698