Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1515103003: Revert of Removal of geolocation APIs on insecure origins (Closed)

Created:
2 years, 11 months ago by johnme
Modified:
2 years, 11 months ago
CC:
blink-reviews, chromium-reviews, jochen (gone - plz use gerrit), mlamouri+watch-blink_chromium.org, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/src@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Removal of geolocation APIs on insecure origins (patchset #6 id:100001 of https://codereview.chromium.org/1485973002/ ) Reason for revert: Sorry, this broke the following WebView CTS tests: android.webkit.cts.GeolocationTest#testSimpleGeolocationRequestAcceptAlways android.webkit.cts.GeolocationTest#testSimpleGeolocationRequestAcceptOnce android.webkit.cts.GeolocationTest#testSimpleGeolocationRequestReject See https://build.chromium.org/p/chromium.android/builders/Android%20WebView%20CTS%20L-MR1%20%28dbg%29/builds/4704 It seems that might be intentional, but turning the bot red doesn't seem great. sgurun@ can probably advise on whether WebView has test expectations for CTS, that could be used to disable these tests. Original issue's description: > Removal of geolocation APIs on insecure origins > > This disallows the geolocation APIs getCurrentPosition() and > watchPosition() from being used on insecure origins. Adds a console > warning message that the API call has failed because of this. > > BUG=520765, 561641 > > Committed: https://crrev.com/33ef9f5c8df422b0320cbc506d57bdce2999ebc8 > Cr-Commit-Position: refs/heads/master@{#364642} TBR=mlamouri@chromium.org,philipj@opera.com,thestig@chromium.org,sgurun@chromium.org,torne@chromium.org,jww@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=520765, 561641 Committed: https://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15 Cr-Commit-Position: refs/heads/master@{#364689}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
johnme
Created Revert of Removal of geolocation APIs on insecure origins
2 years, 11 months ago (2015-12-11 13:24:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515103003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515103003/1
2 years, 11 months ago (2015-12-11 13:25:25 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
2 years, 11 months ago (2015-12-11 13:26:40 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15 Cr-Commit-Position: refs/heads/master@{#364689}
2 years, 11 months ago (2015-12-11 13:28:00 UTC) #6
sgurun-gerrit only
2 years, 11 months ago (2015-12-11 16:22:48 UTC) #7
Message was sent while issue was closed.
On 2015/12/11 13:28:00, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/ecdcb8846d510107b97b8401b81ec06462420f15
> Cr-Commit-Position: refs/heads/master@{#364689}

thanks for noticing that. Yeah, this would be ugly, once we release that it will
break cts tests which partners need to pass to release their devices.

Powered by Google App Engine
This is Rietveld 408576698