Streamline SIMD targets in media.gyp

media/base/simd/convert_rgb_to_yuv.h

Index: media/base/simd/convert_rgb_to_yuv.h
diff --git a/media/base/simd/convert_rgb_to_yuv.h b/media/base/simd/convert_rgb_to_yuv.h
index 03fe1140c47990cc65f20eeb2b867d191cbd77a8..25db6538350b752e6c5b23a7f3ac31ca756f303d 100644
--- a/media/base/simd/convert_rgb_to_yuv.h
+++ b/media/base/simd/convert_rgb_to_yuv.h
@@ -13,43 +13,54 @@ namespace media {
 // Converts an ARGB image to a YV12 image. This function calls ASM functions
 // implemented in "convert_rgb_to_yuv_ssse3.asm" to convert the specified ARGB
 // image to a YV12 image.
-void ConvertRGB32ToYUV_SSSE3(const uint8* rgbframe,
-                             uint8* yplane,
-                             uint8* uplane,
-                             uint8* vplane,
-                             int width,
-                             int height,
-                             int rgbstride,
-                             int ystride,
-                             int uvstride);
+MEDIA_EXPORT void ConvertRGB32ToYUV_SSSE3(const uint8* rgbframe,
+                                          uint8* yplane,
+                                          uint8* uplane,
+                                          uint8* vplane,
+                                          int width,
+                                          int height,
+                                          int rgbstride,
+                                          int ystride,
+                                          int uvstride);
 
 // Converts an RGB image to a YV12 image. This function is almost same as
 // ConvertRGB32ToYUV_SSSE3 except its first argument is a pointer to RGB pixels.
-void ConvertRGB24ToYUV_SSSE3(const uint8* rgbframe,
-                             uint8* yplane,
-                             uint8* uplane,
-                             uint8* vplane,
-                             int width,
-                             int height,
-                             int rgbstride,
-                             int ystride,
-                             int uvstride);
+MEDIA_EXPORT void ConvertRGB24ToYUV_SSSE3(const uint8* rgbframe,
+                                          uint8* yplane,
+                                          uint8* uplane,
+                                          uint8* vplane,
+                                          int width,
+                                          int height,
+                                          int rgbstride,
+                                          int ystride,
+                                          int uvstride);
 
 // SSE2 version of converting RGBA to YV12.
-void ConvertRGB32ToYUV_SSE2(const uint8* rgbframe,
-                            uint8* yplane,
-                            uint8* uplane,
-                            uint8* vplane,
-                            int width,
-                            int height,
-                            int rgbstride,
-                            int ystride,
-                            int uvstride);
+MEDIA_EXPORT void ConvertRGB32ToYUV_SSE2(const uint8* rgbframe,
+                                         uint8* yplane,
+                                         uint8* uplane,
+                                         uint8* vplane,
+                                         int width,
+                                         int height,
+                                         int rgbstride,
+                                         int ystride,
+                                         int uvstride);
 
 // This is a C reference implementation of the above routine.
 // This method should only be used in unit test.
 // TODO(hclam): Should use this as the C version of RGB to YUV.

[Ami GONE FROM CHROMIUM, 2013/05/18 02:22:04]

umm, wat?

[DaleCurtis, 2013/05/23 23:43:23]

wakka wakka!

-void ConvertRGB32ToYUV_SSE2_Reference(const uint8* rgbframe,
+MEDIA_EXPORT void ConvertRGB32ToYUV_SSE2_Reference(const uint8* rgbframe,
+                                                   uint8* yplane,
+                                                   uint8* uplane,
+                                                   uint8* vplane,
+                                                   int width,
+                                                   int height,
+                                                   int rgbstride,
+                                                   int ystride,
+                                                   int uvstride);
+
+// C version of converting RGBA to YV12.

[Ami GONE FROM CHROMIUM, 2013/05/18 02:22:04]

This and most of the rest the one-liner comments in this file make me think:
\cage{you don't say??}

[DaleCurtis, 2013/05/23 23:43:23]

Like Cage in Knowing, they've embraced the sun's not so gentle caress.

+MEDIA_EXPORT void ConvertRGB32ToYUV_C(const uint8* rgbframe,
                                       uint8* yplane,
                                       uint8* uplane,
                                       uint8* vplane,
@@ -59,27 +70,16 @@ void ConvertRGB32ToYUV_SSE2_Reference(const uint8* rgbframe,
                                       int ystride,
                                       int uvstride);
 
-// C version of converting RGBA to YV12.
-void ConvertRGB32ToYUV_C(const uint8* rgbframe,
-                         uint8* yplane,
-                         uint8* uplane,
-                         uint8* vplane,
-                         int width,
-                         int height,
-                         int rgbstride,
-                         int ystride,
-                         int uvstride);
-
 // C version of converting RGB24 to YV12.
-void ConvertRGB24ToYUV_C(const uint8* rgbframe,
-                         uint8* yplane,
-                         uint8* uplane,
-                         uint8* vplane,
-                         int width,
-                         int height,
-                         int rgbstride,
-                         int ystride,
-                         int uvstride);
+MEDIA_EXPORT void ConvertRGB24ToYUV_C(const uint8* rgbframe,
+                                      uint8* yplane,
+                                      uint8* uplane,
+                                      uint8* vplane,
+                                      int width,
+                                      int height,
+                                      int rgbstride,
+                                      int ystride,
+                                      int uvstride);
 
 }  // namespace media