Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1702)

Unified Diff: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc

Issue 151503006: Re-land r248110 with ASAN error fixed. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
diff --git a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
index 5e306e8fea8b956afa140ed0ffb815338c2f42f2..9c3dfdb3ce4accbe48189075719eec96186f60e6 100644
--- a/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
+++ b/chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc
@@ -144,6 +144,13 @@ void TabAutofillManagerDelegate::UpdateAutofillPopupDataListValues(
void TabAutofillManagerDelegate::HideAutofillPopup() {
if (popup_controller_.get())
popup_controller_->Hide();
+
+ // Password generation popups behave in the same fashion and should also
+ // be hidden.
+ PasswordGenerationManager* generation_manager =
+ PasswordGenerationManager::FromWebContents(web_contents_);
+ if (generation_manager)
+ generation_manager->HidePopup();
}
bool TabAutofillManagerDelegate::IsAutocompleteEnabled() {

Powered by Google App Engine
This is Rietveld 408576698