Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Issue 151503006: Re-land r248110 with ASAN error fixed. (Closed)

Created:
6 years, 10 months ago by Garrett Casto
Modified:
6 years, 10 months ago
CC:
chromium-reviews, asvitkine+watch_chromium.org, jar (doing other things), benquan, jam, browser-components-watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, android-webview-reviews_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Re-land r248110 "[Password Generation] Enable new UI" Replaces key icon and associated bubble with autofill style dropdown. Changes include - Update PasswordGenerationAgentTest - Add interactive_uitest for new UI. - Sync edits to confirmation password field(s). - Update UMA stats to more accurately reflect user choices. Updating the generation popup to match the latest mocks and implement the editing popup will come in a later CL. This reverts r248119 and fixes a use-after-free in PasswordGenerationPopupControllerImpl::PossiblyAcceptPassword() R=asvitkine@chromium.org, estade@chromium.org TBR=kenrb@chromium.org, sky@chromium.org, torne@chromium.org BUG=318977 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=248297

Patch Set 1 #

Patch Set 2 : Original #

Patch Set 3 : With Fix #

Total comments: 4

Patch Set 4 : Comments #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : Punctuation #

Unified diffs Side-by-side diffs Delta from patch set Stats (+703 lines, -172 lines) Patch
M android_webview/renderer/aw_content_renderer_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A chrome/browser/password_manager/password_generation_interactive_uitest.cc View 1 chunk +147 lines, -0 lines 0 comments Download
M chrome/browser/password_manager/password_generation_manager.h View 3 chunks +31 lines, -4 lines 0 comments Download
M chrome/browser/password_manager/password_generation_manager.cc View 5 chunks +55 lines, -10 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.h View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc View 1 2 3 4 5 3 chunks +10 lines, -4 lines 0 comments Download
A chrome/browser/ui/autofill/password_generation_popup_view.cc View 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/browser/ui/autofill/tab_autofill_manager_delegate.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +5 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/renderer/autofill/password_generation_agent_browsertest.cc View 9 chunks +62 lines, -84 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/test/base/chrome_render_view_test.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M components/autofill/content/common/autofill_messages.h View 1 chunk +10 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.h View 3 chunks +7 lines, -2 lines 0 comments Download
M components/autofill/content/renderer/autofill_agent.cc View 3 chunks +9 lines, -9 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/form_autofill_util.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.h View 4 chunks +37 lines, -3 lines 0 comments Download
M components/autofill/content/renderer/password_generation_agent.cc View 7 chunks +134 lines, -35 lines 0 comments Download
A components/autofill/content/renderer/test_password_generation_agent.h View 1 chunk +44 lines, -0 lines 0 comments Download
A components/autofill/content/renderer/test_password_generation_agent.cc View 1 chunk +33 lines, -0 lines 0 comments Download
M components/autofill/core/common/autofill_switches.h View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/common/autofill_switches.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/autofill/core/common/password_generation_util.h View 2 chunks +25 lines, -4 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Garrett Casto
Cleaned up a use-after-free in PasswordGenerationPopupControllerImpl::PossiblyAcceptPassword().
6 years, 10 months ago (2014-01-31 20:01:10 UTC) #1
Evan Stade
https://codereview.chromium.org/151503006/diff/60001/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc File chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc (right): https://codereview.chromium.org/151503006/diff/60001/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc#newcode108 chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc:108: // We supress tab if the password is selected ...
6 years, 10 months ago (2014-01-31 21:55:54 UTC) #2
Garrett Casto
https://codereview.chromium.org/151503006/diff/60001/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc File chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc (right): https://codereview.chromium.org/151503006/diff/60001/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc#newcode108 chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc:108: // We supress tab if the password is selected ...
6 years, 10 months ago (2014-01-31 22:01:41 UTC) #3
Alexei Svitkine (slow)
re-lgtm for histograms
6 years, 10 months ago (2014-01-31 22:02:28 UTC) #4
Garrett Casto
On 2014/01/31 22:02:28, Alexei Svitkine wrote: > re-lgtm for histograms Try bots are being strange, ...
6 years, 10 months ago (2014-01-31 22:17:13 UTC) #5
Evan Stade
lgtm https://codereview.chromium.org/151503006/diff/110002/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc File chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc (right): https://codereview.chromium.org/151503006/diff/110002/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc#newcode118 chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc:118: PasswordAccepted(); // This will delete |this| nit: final ...
6 years, 10 months ago (2014-01-31 22:39:56 UTC) #6
Garrett Casto
https://codereview.chromium.org/151503006/diff/110002/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc File chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc (right): https://codereview.chromium.org/151503006/diff/110002/chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc#newcode118 chrome/browser/ui/autofill/password_generation_popup_controller_impl.cc:118: PasswordAccepted(); // This will delete |this| On 2014/01/31 22:39:57, ...
6 years, 10 months ago (2014-01-31 22:57:59 UTC) #7
Garrett Casto
6 years, 10 months ago (2014-01-31 23:12:28 UTC) #8
Message was sent while issue was closed.
Committed patchset #6 manually as r248297 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698