Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Unified Diff: chrome/browser/media/cast_transport_host_filter.h

Issue 1515023002: Simplify interface for media/cast: CastTransportSenderImpl (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: New version: move creating UdpTransport out and use setters for options. Created 4 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/cast_transport_host_filter.h
diff --git a/chrome/browser/media/cast_transport_host_filter.h b/chrome/browser/media/cast_transport_host_filter.h
index 127e7d1c89d7bef5f980e028a8f0004eafd7aa35..7030954cc6f75957ea91ed42f4c6aed1899642ce 100644
--- a/chrome/browser/media/cast_transport_host_filter.h
+++ b/chrome/browser/media/cast_transport_host_filter.h
@@ -16,6 +16,7 @@
#include "media/cast/cast_sender.h"
#include "media/cast/logging/logging_defines.h"
#include "media/cast/net/cast_transport_sender.h"
+#include "media/cast/net/udp_transport.h"
namespace content {
class PowerSaveBlocker;
@@ -30,18 +31,13 @@ class CastTransportHostFilter : public content::BrowserMessageFilter {
private:
~CastTransportHostFilter() override;
- void NotifyStatusChange(int32_t channel_id,
- media::cast::CastTransportStatus result);
- void SendRawEvents(
- int32_t channel_id,
- scoped_ptr<std::vector<media::cast::FrameEvent>> frame_events,
- scoped_ptr<std::vector<media::cast::PacketEvent>> packet_events);
+ // Status callback to create UdpTransport.
+ void OnStatusChanged(int32_t channel_id,
+ media::cast::CastTransportStatus status);
void SendRtt(int32_t channel_id, uint32_t ssrc, base::TimeDelta rtt);
void SendCastMessage(int32_t channel_id,
uint32_t ssrc,
const media::cast::RtcpCastMessage& cast_message);
- void ReceivedPacket(int32_t channel_id,
- scoped_ptr<media::cast::Packet> packet);
// BrowserMessageFilter implementation.
bool OnMessageReceived(const IPC::Message& message) override;
@@ -70,12 +66,39 @@ class CastTransportHostFilter : public content::BrowserMessageFilter {
int32_t channel_id,
const media::cast::SendRtcpFromRtpReceiver_Params& params);
+ // |options| contains optional settings for the transport, possible
+ // keys are:
+ // "DSCP" (value ignored)
+ // - Turns DSCP on (higher IP Precedence and Type of Service).
+ // "disable_non_blocking_io" (value ignored)
+ // - Windows only. Turns off non-blocking IO for the socket.
+ // Note: Non-blocking IO is, by default, enabled on all platforms.
+ // "pacer_target_burst_size": int
+ // - Specifies how many packets to send per 10 ms ideally.
+ // "pacer_max_burst_size": int
+ // - Specifies how many pakcets to send per 10 ms, maximum.
+ // "send_buffer_min_size": int
+ // - Specifies the minimum socket send buffer size.
+ // "disable_wifi_scan" (value ignored)
+ // - Disable wifi scans while streaming.
+ // "media_streaming_mode" (value ignored)
+ // - Turn media streaming mode on.
+ // Note, these options may be ignored on some platforms.
void OnNew(int32_t channel_id,
const net::IPEndPoint& local_end_point,
const net::IPEndPoint& remote_end_point,
const base::DictionaryValue& options);
void OnDelete(int32_t channel_id);
+ void SetUdpOptions(media::cast::UdpTransport* transport,
+ const base::DictionaryValue& options);
+
+ void SetPacedSenderOptions(media::cast::CastTransportSender* transport_sender,
+ const base::DictionaryValue& options);
+
+ void SetWifiOptions(media::cast::CastTransportSender* transport_sender,
+ const base::DictionaryValue& options);
+
IDMap<media::cast::CastTransportSender, IDMapOwnPointer> id_map_;
// Clock used by Cast transport.
« no previous file with comments | « no previous file | chrome/browser/media/cast_transport_host_filter.cc » ('j') | chrome/renderer/media/cast_transport_sender_ipc.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698