Simplify interface for media/cast: CastTransportSenderImpl

media/cast/test/utility/in_process_receiver.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAST_TEST_IN_PROCESS_RECEIVER_H_
 #define MEDIA_CAST_TEST_IN_PROCESS_RECEIVER_H_
 
 #include "base/macros.h"
 #include "base/memory/ref_counted.h"
 #include "base/memory/scoped_ptr.h"
@@ skipping 46 matching lines @@
   const FrameReceiverConfig& video_config() const { return video_config_; }
 
   // Begin delivering any received audio/video frames to the OnXXXFrame()
   // methods.
   virtual void Start();
 
   // Destroy the sub-compontents of this class.
   // After this call, it is safe to destroy this object on any thread.
   virtual void Stop();
 
+  void ReceivePacket(scoped_ptr<Packet> packet);

[miu, 2016/02/22 22:38:48]

Don't make this method public.  Instead, make the TransportClient class an inner
class of InProcessReceiver so that it is allowed to call the private method.

[xjz, 2016/02/23 21:51:47]

Done.

+
  protected:
   // To be implemented by subclasses.  These are called on the Cast MAIN thread
   // as each frame is received.
   virtual void OnAudioFrame(scoped_ptr<AudioBus> audio_frame,
                             const base::TimeTicks& playout_time,
                             bool is_continuous) = 0;
   virtual void OnVideoFrame(const scoped_refptr<VideoFrame>& video_frame,
                             const base::TimeTicks& playout_time,
                             bool is_continuous) = 0;
 
@@ skipping 18 matching lines @@
   // argument description and semantics.
   void GotAudioFrame(scoped_ptr<AudioBus> audio_frame,
                      const base::TimeTicks& playout_time,
                      bool is_continuous);
   void GotVideoFrame(const scoped_refptr<VideoFrame>& video_frame,
                      const base::TimeTicks& playout_time,
                      bool is_continuous);
   void PullNextAudioFrame();
   void PullNextVideoFrame();
 
-  void ReceivePacket(scoped_ptr<Packet> packet);
-
   const scoped_refptr<CastEnvironment> cast_environment_;
   const net::IPEndPoint local_end_point_;
   const net::IPEndPoint remote_end_point_;
   const FrameReceiverConfig audio_config_;
   const FrameReceiverConfig video_config_;
 
   scoped_ptr<CastTransportSender> transport_;
   scoped_ptr<CastReceiver> cast_receiver_;
 
   // NOTE: Weak pointers must be invalidated before all other member variables.
   base::WeakPtrFactory<InProcessReceiver> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(InProcessReceiver);
 };
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_TEST_IN_PROCESS_RECEIVER_H_