Simplify interface for media/cast: CastTransportSenderImpl

media/cast/net/cast_transport_config.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_CAST_NET_CAST_TRANSPORT_CONFIG_H_
 #define MEDIA_CAST_NET_CAST_TRANSPORT_CONFIG_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 120 matching lines @@
   // Send a packet to the network. Returns false if the network is blocked
   // and we should wait for |cb| to be called. It is not allowed to called
   // SendPacket again until |cb| has been called. Any other errors that
   // occur will be reported through side channels, in such cases, this function
   // will return true indicating that the channel is not blocked.
   virtual bool SendPacket(PacketRef packet, const base::Closure& cb) = 0;
 
   // Returns the number of bytes ever sent.
   virtual int64_t GetBytesSent() = 0;
 
+  virtual void StartReceiving(

[miu, 2016/02/22 22:38:48]

1. These methods don't belong in a "PacketSender" interface.  Looking at what
they're here for, perhaps this class should be renamed to something like, say,
PacketTransporter?

2. Please add comments for these methods.

[xjz, 2016/02/23 21:51:46]

Agree. Will rename it in a following CL together with the renaming of
CastTransportSender. Added a TODO comment here for now.
Done.

+      const PacketReceiverCallbackWithStatus& packet_receiver) = 0;
+  virtual void StopReceiving() = 0;
+
   virtual ~PacketSender() {}
 };
 
 struct RtcpSenderInfo {
   RtcpSenderInfo();
   ~RtcpSenderInfo();
   // First three members are used for lipsync.
   // Last two members are used for rtt.
   uint32_t ntp_seconds;
   uint32_t ntp_fraction;
@@ skipping 27 matching lines @@
          lhs.ntp_fraction == rhs.ntp_fraction &&
          lhs.rtp_timestamp == rhs.rtp_timestamp &&
          lhs.send_packet_count == rhs.send_packet_count &&
          lhs.send_octet_count == rhs.send_octet_count;
 }
 
 }  // namespace cast
 }  // namespace media
 
 #endif  // MEDIA_CAST_NET_CAST_TRANSPORT_CONFIG_H_