Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1515003002: Fix new Mojo EDK multiplexing code on Android. (Closed)

Created:
5 years ago by jam
Modified:
5 years ago
Reviewers:
yzshen1
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix new Mojo EDK multiplexing code on Android. It was doing an unaligned read of an uint64_t which was causing crashes on ARM devices. BUG=561803 Committed: https://crrev.com/c5ca2472f5ee4edc633ea8a0a63ad90de4f594c6 Cr-Commit-Position: refs/heads/master@{#364569}

Patch Set 1 : #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -20 lines) Patch
M mojo/edk/system/routed_raw_channel.cc View 3 chunks +8 lines, -20 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
jam
5 years ago (2015-12-10 22:49:31 UTC) #2
yzshen1
lgtm
5 years ago (2015-12-10 22:51:44 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515003002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515003002/60001
5 years ago (2015-12-10 23:38:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1515003002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1515003002/60001
5 years ago (2015-12-11 00:39:48 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:60001)
5 years ago (2015-12-11 01:30:07 UTC) #14
commit-bot: I haz the power
5 years ago (2015-12-11 01:31:01 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/c5ca2472f5ee4edc633ea8a0a63ad90de4f594c6
Cr-Commit-Position: refs/heads/master@{#364569}

Powered by Google App Engine
This is Rietveld 408576698