Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 1514993002: Disable new regression tests with noi18n (Closed)

Created:
5 years ago by Dan Ehrenberg
Modified:
5 years ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Disable new regression tests with noi18n BUG=chromium:487322 R=adamk LOG=N Committed: https://crrev.com/46cb23c24b518114151c181bd75f628c2cee0f9e Cr-Commit-Position: refs/heads/master@{#32770}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M test/mjsunit/regress/regress-487322.js View 1 chunk +9 lines, -7 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Dan Ehrenberg
5 years ago (2015-12-10 21:49:33 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514993002/1
5 years ago (2015-12-10 21:49:44 UTC) #5
adamk
lgtm to get the build green, but maybe we need mjsunit/intl/ as we add more ...
5 years ago (2015-12-10 22:22:59 UTC) #6
adamk
Also this is probably a LOG=N situation
5 years ago (2015-12-10 22:23:29 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514993002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514993002/1
5 years ago (2015-12-10 22:23:31 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 22:51:59 UTC) #12
commit-bot: I haz the power
5 years ago (2015-12-10 22:52:53 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/46cb23c24b518114151c181bd75f628c2cee0f9e
Cr-Commit-Position: refs/heads/master@{#32770}

Powered by Google App Engine
This is Rietveld 408576698