Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 151483012: Make sure AllowRepaintScope::m_originalValue is always initialized (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
CC:
blink-reviews, chrishtr, dsinclair
Visibility:
Public.

Description

Make sure AllowRepaintScope::m_originalValue is always initialized Make sure AllowRepaintScope::m_originalValue is always initialized. This fixes a build error with gcc 4.8: """ core/frame/FrameView.h:567:65: error: ‘*((void*)& scoper +8)’ may be used uninitialized in this function [-Werror=maybe-uninitialized] """ R=abarth@chromium.org, abarth, eseidel Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=166885

Patch Set 1 #

Patch Set 2 : Slight cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/frame/FrameView.h View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Inactive
The full build error is: """ In file included from ../../third_party/WebKit/Source/core/rendering/RenderLayerScrollableArea.cpp:55:0: ../../third_party/WebKit/Source/core/frame/FrameView.h: In member function ...
6 years, 10 months ago (2014-02-11 01:00:12 UTC) #1
Inactive
+dsinclair in cc
6 years, 10 months ago (2014-02-11 01:01:51 UTC) #2
abarth-chromium
lgtm
6 years, 10 months ago (2014-02-11 01:07:57 UTC) #3
Inactive
6 years, 10 months ago (2014-02-11 01:40:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r166885 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698