Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1390)

Unified Diff: cc/trees/layer_tree_host_unittest.cc

Issue 1514743002: cc: turn on strict paint property checking (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/layers/layer.cc ('k') | cc/trees/layer_tree_settings.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_unittest.cc
diff --git a/cc/trees/layer_tree_host_unittest.cc b/cc/trees/layer_tree_host_unittest.cc
index 6974c92a406004568416a276d60a93c2b41d2948..575a367bca1e9fa856812379ff751bca4a389fab 100644
--- a/cc/trees/layer_tree_host_unittest.cc
+++ b/cc/trees/layer_tree_host_unittest.cc
@@ -1564,65 +1564,6 @@ class LayerTreeHostTestSetVisible : public LayerTreeHostTest {
MULTI_THREAD_TEST_F(LayerTreeHostTestSetVisible);
-class TestOpacityChangeLayerDelegate : public ContentLayerClient {
- public:
- TestOpacityChangeLayerDelegate() : test_layer_(0) {}
-
- void SetTestLayer(Layer* test_layer) { test_layer_ = test_layer; }
-
- gfx::Rect PaintableRegion() override {
- return gfx::Rect(test_layer_->bounds());
- }
- scoped_refptr<DisplayItemList> PaintContentsToDisplayList(
- PaintingControlSetting picture_control) override {
- // Set layer opacity to 0.
- if (test_layer_)
- test_layer_->SetOpacity(0.f);
-
- // Return a dummy display list.
- scoped_refptr<DisplayItemList> display_list =
- DisplayItemList::Create(PaintableRegion(), DisplayItemListSettings());
- return display_list;
- }
- bool FillsBoundsCompletely() const override { return false; }
- size_t GetApproximateUnsharedMemoryUsage() const override { return 0; }
-
- private:
- Layer* test_layer_;
-};
-
-// Layer opacity change during paint should not prevent compositor resources
-// from being updated during commit.
-class LayerTreeHostTestOpacityChange : public LayerTreeHostTest {
- public:
- LayerTreeHostTestOpacityChange() : test_opacity_change_delegate_() {}
-
- void SetupTree() override {
- LayerTreeHostTest::SetupTree();
-
- update_check_picture_layer_ = FakePictureLayer::Create(
- layer_settings(), &test_opacity_change_delegate_);
- test_opacity_change_delegate_.SetTestLayer(
- update_check_picture_layer_.get());
- layer_tree_host()->root_layer()->AddChild(update_check_picture_layer_);
- }
-
- void BeginTest() override { PostSetNeedsCommitToMainThread(); }
-
- void CommitCompleteOnThread(LayerTreeHostImpl* impl) override { EndTest(); }
-
- void AfterTest() override {
- // Update() should have been called once.
- EXPECT_EQ(1, update_check_picture_layer_->update_count());
- }
-
- private:
- TestOpacityChangeLayerDelegate test_opacity_change_delegate_;
- scoped_refptr<FakePictureLayer> update_check_picture_layer_;
-};
-
-MULTI_THREAD_TEST_F(LayerTreeHostTestOpacityChange);
-
class LayerTreeHostTestDeviceScaleFactorScalesViewportAndLayers
: public LayerTreeHostTest {
public:
@@ -2173,70 +2114,6 @@ class LayerTreeHostTestUninvertibleTransformDoesNotBlockActivation
SINGLE_AND_MULTI_THREAD_TEST_F(
LayerTreeHostTestUninvertibleTransformDoesNotBlockActivation);
-class LayerTreeHostTestChangeLayerPropertiesInPaintContents
- : public LayerTreeHostTest {
- public:
- class SetBoundsClient : public ContentLayerClient {
- public:
- SetBoundsClient() : layer_(0) {}
-
- void set_layer(Layer* layer) { layer_ = layer; }
-
- gfx::Rect PaintableRegion() override { return gfx::Rect(layer_->bounds()); }
-
- scoped_refptr<DisplayItemList> PaintContentsToDisplayList(
- PaintingControlSetting picture_control) override {
- layer_->SetBounds(gfx::Size(2, 2));
-
- // Return a dummy display list.
- scoped_refptr<DisplayItemList> display_list =
- DisplayItemList::Create(PaintableRegion(), DisplayItemListSettings());
- return display_list;
- }
-
- bool FillsBoundsCompletely() const override { return false; }
- size_t GetApproximateUnsharedMemoryUsage() const override { return 0; }
-
- private:
- Layer* layer_;
- };
-
- LayerTreeHostTestChangeLayerPropertiesInPaintContents() : num_commits_(0) {}
-
- void SetupTree() override {
- scoped_refptr<PictureLayer> root_layer =
- PictureLayer::Create(layer_settings(), &client_);
- root_layer->SetIsDrawable(true);
- root_layer->SetBounds(gfx::Size(1, 1));
- client_.set_layer(root_layer.get());
-
- layer_tree_host()->SetRootLayer(root_layer);
- LayerTreeHostTest::SetupTree();
- }
-
- void BeginTest() override { PostSetNeedsCommitToMainThread(); }
- void AfterTest() override {}
-
- void DidActivateTreeOnThread(LayerTreeHostImpl* host_impl) override {
- num_commits_++;
- if (num_commits_ == 1) {
- LayerImpl* root_layer = host_impl->active_tree()->root_layer();
- EXPECT_EQ(gfx::Size(1, 1), root_layer->bounds());
- } else {
- LayerImpl* root_layer = host_impl->active_tree()->root_layer();
- EXPECT_EQ(gfx::Size(2, 2), root_layer->bounds());
- EndTest();
- }
- }
-
- private:
- SetBoundsClient client_;
- int num_commits_;
-};
-
-SINGLE_AND_MULTI_THREAD_TEST_F(
- LayerTreeHostTestChangeLayerPropertiesInPaintContents);
-
class MockIOSurfaceWebGraphicsContext3D : public TestWebGraphicsContext3D {
public:
MockIOSurfaceWebGraphicsContext3D() {
« no previous file with comments | « cc/layers/layer.cc ('k') | cc/trees/layer_tree_settings.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698