third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp - Issue 1514733002: Avoid unnecessary invalidation scheduling.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

Issue 1514733002: Avoid unnecessary invalidation scheduling. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Removed unnecessary isMaster check Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp ('k') | third_party/WebKit/Source/core/dom/Element.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

diff --git a/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp b/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

index 453479c8ce684b202d19f90d1ff2e7c511924bf1..d8543093af7228db4c4da7979bf302ec2a8260e4 100644

--- a/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

+++ b/third_party/WebKit/Source/core/css/invalidation/StyleInvalidator.cpp

@@ -61,13 +61,16 @@ void StyleInvalidator::scheduleInvalidationSetsForElement(const InvalidationList

}

- if (invalidationLists.siblings.isEmpty() && !requiresDescendantInvalidation)

+ if (!requiresDescendantInvalidation && (invalidationLists.siblings.isEmpty() || !element.nextSibling()))

return;

element.setNeedsStyleInvalidation();

PendingInvalidations& pendingInvalidations = ensurePendingInvalidations(element);

- for (auto& invalidationSet : invalidationLists.siblings)

- pendingInvalidations.siblings().append(invalidationSet);

+ if (element.nextSibling()) {

+ for (auto& invalidationSet : invalidationLists.siblings)

+ pendingInvalidations.siblings().append(invalidationSet);

+ }

if (!requiresDescendantInvalidation)

return;