Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1150)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 15147002: Set preloaded HSTS policy for Google Translate. (Closed)

Created:
7 years, 7 months ago by palmer
Modified:
7 years, 4 months ago
Reviewers:
agl, Ryan Sleevi
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Set preloaded HSTS policy for Google Translate. BUG=240490 TEST=translate.google.com, and Chrome's "Translate This Page" feature, still work. R=agl@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=218773

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move translate.googleapis.com directive to appropriate section. #

Patch Set 3 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M net/http/transport_security_state_static.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M net/http/transport_security_state_static.json View 1 2 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
palmer
PTAL. Thanks!
7 years, 7 months ago (2013-05-13 23:05:37 UTC) #1
agl
https://codereview.chromium.org/15147002/diff/1/net/http/transport_security_state_static.json File net/http/transport_security_state_static.json (right): https://codereview.chromium.org/15147002/diff/1/net/http/transport_security_state_static.json#newcode208 net/http/transport_security_state_static.json:208: { "name": "translate.googleapis.com", "include_subdomains": true, "mode": "force-https", "pins": "google" ...
7 years, 7 months ago (2013-05-13 23:09:15 UTC) #2
palmer
https://codereview.chromium.org/15147002/diff/1/net/http/transport_security_state_static.json File net/http/transport_security_state_static.json (right): https://codereview.chromium.org/15147002/diff/1/net/http/transport_security_state_static.json#newcode208 net/http/transport_security_state_static.json:208: { "name": "translate.googleapis.com", "include_subdomains": true, "mode": "force-https", "pins": "google" ...
7 years, 7 months ago (2013-05-13 23:11:43 UTC) #3
agl
LGTM assuming that translate team are happy.
7 years, 7 months ago (2013-05-13 23:13:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/15147002/5001
7 years, 7 months ago (2013-05-20 17:32:38 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=3768
7 years, 7 months ago (2013-05-20 18:23:33 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/15147002/5001
7 years, 7 months ago (2013-05-20 18:42:16 UTC) #7
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=3777
7 years, 7 months ago (2013-05-20 18:50:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/palmer@chromium.org/15147002/18001
7 years, 4 months ago (2013-08-20 23:47:21 UTC) #9
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=21616
7 years, 4 months ago (2013-08-21 06:22:49 UTC) #10
palmer
7 years, 4 months ago (2013-08-21 17:39:21 UTC) #11
Message was sent while issue was closed. 
Committed patchset #3 manually as r218773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698