Updates to the stress test

Updates to the stress test

R=skybrian@google.com

Committed: https://github.com/dart-lang/sdk/commit/aca32e681af368526ee662c5989eb7f41093c96e

[Brian Wilkerson, 2015-12-11 21:39:19]

brianwilkerson@google.com changed reviewers:
+ skybrian@google.com

[skybrian, 2015-12-12 02:01:20]

lgtm

I didn't see any bugs, but at this point I don't really expect to.

I was wondering what happens after removing the overlays. Are the changes from
the git repo ever written to disk?

https://codereview.chromium.org/1514693013/diff/1/pkg/analysis_server/test/st...
File pkg/analysis_server/test/stress/replay/replay.dart (right):

https://codereview.chromium.org/1514693013/diff/1/pkg/analysis_server/test/st...
pkg/analysis_server/test/stress/replay/replay.dart:38: /**
Any plans to switch to '///' in the analyzer?

https://codereview.chromium.org/1514693013/diff/1/pkg/analysis_server/test/st...
pkg/analysis_server/test/stress/replay/replay.dart:228: List<int>
_getBreakOffsets(String text) {
It seems like we could simulate typing one character at a time, or in random
chunks? Users can stop typing at any point.

[Brian Wilkerson, 2015-12-12 15:28:23]

> I was wondering what happens after removing the overlays. Are the changes from
the git repo ever written to disk?

The content of disk will be updated when we 'git checkout' the next revision.
The way the code currently works is that it (1) sends overlays to the server,
(2) gathers all of the errors, (3) checks out the next revision, (4) removes the
overlays, (5) gathers all of the errors, and (6) compares the two sets of errors
to ensure that they're the same. (Errors are one of the few ways we have to test
whether the server is in a bad state.) (The "gather the errors" phase is
incomplete because the code isn't yet maintaining a list of files that are being
analyzed.)

We should do a walk through on Monday of both how the code currently works and
some ideas I had for extending it. Also eager to hear your ideas for where this
could go.

https://codereview.chromium.org/1514693013/diff/1/pkg/analysis_server/test/st...
File pkg/analysis_server/test/stress/replay/replay.dart (right):

https://codereview.chromium.org/1514693013/diff/1/pkg/analysis_server/test/st...
pkg/analysis_server/test/stress/replay/replay.dart:38: /**
> Any plans to switch to '///' in the analyzer?

Nope. At least two of us really dislike that form of doc comment. Happy to
discuss why off line.

https://codereview.chromium.org/1514693013/diff/1/pkg/analysis_server/test/st...
pkg/analysis_server/test/stress/replay/replay.dart:228: List<int>
_getBreakOffsets(String text) {
> It seems like we could simulate typing one character at a time, or in random
> chunks? Users can stop typing at any point.

We're trying to simulate how the client (editor) works, and most clients batch
up strings of characters (typically based on the speed of typing, sending a
batch when there's a "significant" pause in typing), so I wouldn't do one
character at a time.

But yes, breaking up tokens seemed reasonable to me (see lines 240-242).

[Brian Wilkerson, 2015-12-12 15:28:48]

Description was changed from

==========
Updates to the stress test
==========

to

==========
Updates to the stress test

R=skybrian@google.com

Committed:
https://github.com/dart-lang/sdk/commit/aca32e681af368526ee662c5989eb7f41093c96e
==========

[Brian Wilkerson, 2015-12-12 15:28:50]

Committed patchset #1 (id:1) manually as
aca32e681af368526ee662c5989eb7f41093c96e (presubmit successful).