Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1322)

Issue 1514633002: XFA: Fix win8 gn build under chromium checkout (non-xfa) (Closed)

Created:
5 years ago by Tom Sepez
Modified:
5 years ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa
Target Ref:
refs/heads/xfa
Visibility:
Public.

Description

XFA: Fix win8 gn build under chromium checkout (non-xfa) The no nominmax config was lost when moving from master. Fix a few other small differences along the way, and fully conditionalize the build of tiff. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/465ed873abc829e9dda39f30c8679d2d18721f62

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -98 lines) Patch
M BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/BUILD.gn View 5 chunks +58 lines, -51 lines 0 comments Download
M third_party/base/logging.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/bigint/BigIntegerUtils.cc View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/third_party.gyp View 7 chunks +67 lines, -42 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
Tom Sepez
Lei, this is likely the red trybot during yesterdays trial.
5 years ago (2015-12-09 19:04:57 UTC) #3
Lei Zhang
lgtm
5 years ago (2015-12-09 22:47:12 UTC) #4
Tom Sepez
5 years ago (2015-12-09 22:55:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
465ed873abc829e9dda39f30c8679d2d18721f62 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698