Issue 1514613003: remove argument list suggestions - fixes #25197

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1514613003: remove argument list suggestions - fixes #25197 (Closed)

Created:
5 years ago by danrubel

Modified:
5 years ago

Reviewers:
scheglov

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+42 lines, -35 lines)			Patch
	M	pkg/analysis_server/lib/src/services/completion/dart/arglist_contributor.dart	View		1 chunk	+29 lines, -26 lines	0 comments	Download
	M	pkg/analysis_server/test/services/completion/dart/arglist_contributor_test.dart	View		1 chunk	+13 lines, -9 lines	0 comments	Download

Total messages: 6 (2 generated)

danrubel

Committed patchset #1 (id:1) manually as 29a44c7b4c592616c00bba58157ebcb0c80ff016 (presubmit successful).

5 years ago (2015-12-09 21:06:56 UTC) #5

danrubel

5 years ago (2015-12-09 21:08:19 UTC) #6

Message was sent while issue was closed.

On 2015/12/09 20:58:13, scheglov wrote:
> LGTM
> 
> Why not remove it completely?

Good point. I'll do that in my next CL.