Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Issue 1514603008: Revert of [cctest] Add tests for aborting compaction of pages (Closed)

Created:
5 years ago by Michael Lippautz
Modified:
5 years ago
CC:
v8-reviews_googlegroups.com, Hannes Payer (out of office), ulan
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [cctest] Add tests for aborting compaction of pages (patchset #6 id:140001 of https://codereview.chromium.org/1511933002/ ) Reason for revert: Failing on Win 32bit nosnap: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Win32%20-%20nosnap%20-%20shared/builds/10602 Original issue's description: > [cctest] Add tests for aborting compaction of pages > > Tests for > * aborting a full page. > * partially aborting a page. > * partially aborting a page with pointers between aborted pages. > * partially aborting a page with store buffer entries. > > Also introduces force_oom() which prohibits a old space to > expand > > BUG=chromium:524425 > LOG=N TBR=ulan@chromium.org,hpayer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:524425 Committed: https://crrev.com/a86ddc5bc33c5dc291e9a2962b53490c319a0dff Cr-Commit-Position: refs/heads/master@{#32785}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -385 lines) Patch
M src/heap/heap.h View 3 chunks +0 lines, -6 lines 0 comments Download
M src/heap/heap.cc View 1 chunk +1 line, -2 lines 0 comments Download
M test/cctest/cctest.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M test/cctest/heap/heap-tester.h View 1 chunk +14 lines, -18 lines 0 comments Download
D test/cctest/heap/test-compaction.cc View 1 chunk +0 lines, -344 lines 0 comments Download
M test/cctest/heap/utils-inl.h View 3 chunks +13 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Michael Lippautz
Created Revert of [cctest] Add tests for aborting compaction of pages
5 years ago (2015-12-11 09:49:40 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514603008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514603008/1
5 years ago (2015-12-11 09:49:51 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-11 09:50:05 UTC) #4
commit-bot: I haz the power
5 years ago (2015-12-11 09:50:54 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a86ddc5bc33c5dc291e9a2962b53490c319a0dff
Cr-Commit-Position: refs/heads/master@{#32785}

Powered by Google App Engine
This is Rietveld 408576698