Implement basic USB device enumeration on Android.

Implement basic USB device enumeration on Android.

This patch provides a basic implementation of UsbService::GetDevices on
Android that populates UsbDevice objects by collecting properties of the
Java-side UsbDevice, UsbConfiguration, UsbInterface and UsbEndpoint
objects over JNI.

It does not support opening devices and does not generate device add or
remove notifications.

BUG=549257
Committed: https://crrev.com/8a310851fb144e91d1777112930ac15c0d88577b
Cr-Commit-Position: refs/heads/master@{#367918}

[Reilly Grant (use Gerrit), 2015-12-11 00:09:15]

Description was changed from

==========
Implement basic USB device enumeration on Android.

This patch provides a basic implementation of UsbService::GetDevices on
Android that populates UsbDevice objects by collecting properties of the
Java-side UsbDevice, UsbConfiguration, UsbInterface and UsbEndpoint
objects over JNI.

It does not support opening devices and does not generate device add or
remove notifications.

BUG=549257
==========

to

==========
Implement basic USB device enumeration on Android.

This patch provides a basic implementation of UsbService::GetDevices on
Android that populates UsbDevice objects by collecting properties of the
Java-side UsbDevice, UsbConfiguration, UsbInterface and UsbEndpoint
objects over JNI.

It does not support opening devices and does not generate device add or
remove notifications.

BUG=549257
==========

[Reilly Grant (use Gerrit), 2015-12-11 00:09:15]

reillyg@chromium.org changed reviewers:
+ nasko@chromium.org, scheib@chromium.org, yfriedman@chromium.org

[Reilly Grant (use Gerrit), 2015-12-11 00:09:31]

Please take a look when you get a chance.

[Reilly Grant (use Gerrit), 2015-12-11 01:46:19]

reillyg@chromium.org changed reviewers:
+ qinmin@chromium.org
- scheib@chromium.org

[Reilly Grant (use Gerrit), 2015-12-11 01:46:59]

qinmin@chromium.org, I am told you did a lot of the JNI reviews for
//device/bluetooth. Can you take a look at this as well?

[qinmin, 2016-01-04 19:20:26]

https://codereview.chromium.org/1514603006/diff/20001/device/usb/android/java...
File device/usb/android/java/src/org/chromium/device/usb/ChromeUsbEndpoint.java
(right):

https://codereview.chromium.org/1514603006/diff/20001/device/usb/android/java...
device/usb/android/java/src/org/chromium/device/usb/ChromeUsbEndpoint.java:49:
throw new AssertionError();
you can move this to the switch statement's default:

https://codereview.chromium.org/1514603006/diff/20001/device/usb/android/java...
device/usb/android/java/src/org/chromium/device/usb/ChromeUsbEndpoint.java:74:
throw new AssertionError();
ditto

https://codereview.chromium.org/1514603006/diff/20001/device/usb/usb_device_a...
File device/usb/usb_device_android.cc (right):

https://codereview.chromium.org/1514603006/diff/20001/device/usb/usb_device_a...
device/usb/usb_device_android.cc:83: } else {
you can remove the else statement by early return in the if statement.

[Reilly Grant (use Gerrit), 2016-01-05 01:35:30]

https://codereview.chromium.org/1514603006/diff/20001/device/usb/android/java...
File device/usb/android/java/src/org/chromium/device/usb/ChromeUsbEndpoint.java
(right):

https://codereview.chromium.org/1514603006/diff/20001/device/usb/android/java...
device/usb/android/java/src/org/chromium/device/usb/ChromeUsbEndpoint.java:49:
throw new AssertionError();
On 2016/01/04 at 19:20:26, qinmin wrote:
> you can move this to the switch statement's default:

Done.

https://codereview.chromium.org/1514603006/diff/20001/device/usb/android/java...
device/usb/android/java/src/org/chromium/device/usb/ChromeUsbEndpoint.java:74:
throw new AssertionError();
On 2016/01/04 at 19:20:26, qinmin wrote:
> ditto

Done.

https://codereview.chromium.org/1514603006/diff/20001/device/usb/usb_device_a...
File device/usb/usb_device_android.cc (right):

https://codereview.chromium.org/1514603006/diff/20001/device/usb/usb_device_a...
device/usb/usb_device_android.cc:83: } else {
On 2016/01/04 at 19:20:26, qinmin wrote:
> you can remove the else statement by early return in the if statement.

I don't like that style because here we're choosing between two options not
returning early if a condition is met.

[nasko, 2016-01-06 17:32:34]

The content/ part looks good.

[qinmin, 2016-01-06 18:22:28]

lgtm

[Reilly Grant (use Gerrit), 2016-01-06 18:34:14]

On 2016/01/06 at 17:32:34, nasko wrote:
> The content/ part looks good.

You need to say that differently for the presubmit checks to take you seriously.
:)

[Reilly Grant (use Gerrit), 2016-01-06 18:36:55]

reillyg@chromium.org changed reviewers:
+ pfeldman@chromium.org

[Reilly Grant (use Gerrit), 2016-01-06 18:36:55]

Adding pfeldman for the minor change to android_usb_browsertest.cc and content/
if he wants to review that too.

[nasko, 2016-01-06 18:44:07]

On 2016/01/06 18:34:14, Reilly Grant wrote:
> On 2016/01/06 at 17:32:34, nasko wrote:
> > The content/ part looks good.
> 
> You need to say that differently for the presubmit checks to take you
seriously.
> :)

I didn't want to inadvertently turn things on that others could/should cover :).
LGTM

[pfeldman, 2016-01-06 19:39:05]

lgtm

[Reilly Grant (use Gerrit), 2016-01-06 20:19:11]

The CQ bit was checked by reillyg@chromium.org

[commit-bot: I haz the power, 2016-01-06 20:19:44]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514603006/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514603006/40001

[commit-bot: I haz the power, 2016-01-06 21:25:25]

Description was changed from

==========
Implement basic USB device enumeration on Android.

This patch provides a basic implementation of UsbService::GetDevices on
Android that populates UsbDevice objects by collecting properties of the
Java-side UsbDevice, UsbConfiguration, UsbInterface and UsbEndpoint
objects over JNI.

It does not support opening devices and does not generate device add or
remove notifications.

BUG=549257
==========

to

==========
Implement basic USB device enumeration on Android.

This patch provides a basic implementation of UsbService::GetDevices on
Android that populates UsbDevice objects by collecting properties of the
Java-side UsbDevice, UsbConfiguration, UsbInterface and UsbEndpoint
objects over JNI.

It does not support opening devices and does not generate device add or
remove notifications.

BUG=549257
==========

[commit-bot: I haz the power, 2016-01-06 21:25:25]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-01-06 21:27:08]

Description was changed from

==========
Implement basic USB device enumeration on Android.

This patch provides a basic implementation of UsbService::GetDevices on
Android that populates UsbDevice objects by collecting properties of the
Java-side UsbDevice, UsbConfiguration, UsbInterface and UsbEndpoint
objects over JNI.

It does not support opening devices and does not generate device add or
remove notifications.

BUG=549257
==========

to

==========
Implement basic USB device enumeration on Android.

This patch provides a basic implementation of UsbService::GetDevices on
Android that populates UsbDevice objects by collecting properties of the
Java-side UsbDevice, UsbConfiguration, UsbInterface and UsbEndpoint
objects over JNI.

It does not support opening devices and does not generate device add or
remove notifications.

BUG=549257

Committed: https://crrev.com/8a310851fb144e91d1777112930ac15c0d88577b
Cr-Commit-Position: refs/heads/master@{#367918}
==========

[commit-bot: I haz the power, 2016-01-06 21:27:09]

Patchset 3 (id:??) landed as
https://crrev.com/8a310851fb144e91d1777112930ac15c0d88577b
Cr-Commit-Position: refs/heads/master@{#367918}

[Reilly Grant (use Gerrit), 2016-01-07 15:14:44]

A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1561283003/ by reillyg@chromium.org.

The reason for reverting is: Speculating that this is the cause of issue
575191..