suggest after import prefix in part files - fixes #25023

suggest after import prefix in part files - fixes #25023

R=scheglov@google.com

Committed: https://github.com/dart-lang/sdk/commit/830a37afaeff2e1639c981f0fd98d84ba9db54d5

[danrubel, 2015-12-09 17:13:47]

danrubel@google.com changed reviewers:
+ scheglov@google.com

[scheglov, 2015-12-09 19:24:17]

LGTM

https://codereview.chromium.org/1514603002/diff/20001/pkg/analysis_server/lib...
File
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
(right):

https://codereview.chromium.org/1514603002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart:106:
List<Source> libraries = context.getLibrariesContaining(source);
context.getLibrariesContaining(source) already returns the source itself, if it
is a library.

[danrubel, 2015-12-09 19:32:41]

https://codereview.chromium.org/1514603002/diff/20001/pkg/analysis_server/lib...
File
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart
(right):

https://codereview.chromium.org/1514603002/diff/20001/pkg/analysis_server/lib...
pkg/analysis_server/lib/src/services/completion/dart/completion_manager.dart:106:
List<Source> libraries = context.getLibrariesContaining(source);
On 2015/12/09 19:24:17, scheglov wrote:
> context.getLibrariesContaining(source) already returns the source itself, if
it
> is a library.

Correct... if that information is cached. I don't want to rely on it unless I
have no other choice (e.g. part file).

In addition, if the file does not have a 'part of' directive *and* is referenced
in a part directive from another file, I want to be sure to that _librarySource
= source for the purposes of code completion. This functionality ensures that.

[danrubel, 2015-12-09 19:35:33]

Description was changed from

==========
suggest after import prefix in part files - fixes #25023
==========

to

==========
suggest after import prefix in part files - fixes #25023

R=scheglov@google.com

Committed:
https://github.com/dart-lang/sdk/commit/830a37afaeff2e1639c981f0fd98d84ba9db54d5
==========

[danrubel, 2015-12-09 19:35:34]

Committed patchset #3 (id:40001) manually as
830a37afaeff2e1639c981f0fd98d84ba9db54d5 (presubmit successful).