third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h - Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/PageRuntimeAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.cpp » ('j') | third_party/WebKit/Source/core/inspector/v8/V8DebuggerAgentImpl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h

diff --git a/third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h b/third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h

index 3a20fe7957bbf5ebf2a62f83023011f776089b7b..9c2995bcd0636880bc3cc6479953c8bb909b6ce9 100644

--- a/third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h

+++ b/third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h

@@ -11,18 +11,7 @@

namespace blink {

-class CORE_EXPORT ScriptDebuggerBase : public V8DebuggerClient {

- WTF_MAKE_NONCOPYABLE(ScriptDebuggerBase);

-public:

- ScriptDebuggerBase(v8::Isolate*);

- ~ScriptDebuggerBase() override;

- v8::Local<v8::Object> compileDebuggerScript() override;

- V8Debugger* debugger() const { return m_debugger.get(); }

-private:

- v8::Isolate* m_isolate;

- OwnPtr<V8Debugger> m_debugger;

-};

+v8::Local<v8::Object> compileDebuggerScript(v8::Isolate*);

dgozman 2015/12/10 00:55:12 Perhaps, rename this to DebuggerScript.h?

} // namespace blink