third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp - Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

Issue 1514523004: DevTools: remove V8DebuggerListener and ScriptDebuggerBase abstractions. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.h ('k') | third_party/WebKit/Source/core/core.gypi » ('j') | third_party/WebKit/Source/core/inspector/ScriptDebuggerBase.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

index eba75668214b7f7d13379ddb24d9b6dea8085c69..90c6a91f003fbe5f12d4942b9e0b83da5de9f245 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/V8PerIsolateData.cpp

@@ -34,7 +34,7 @@

#include "bindings/core/v8/V8RecursionScope.h"

#include "bindings/core/v8/V8ScriptRunner.h"

#include "core/frame/UseCounter.h"

-#include "core/inspector/ScriptDebuggerBase.h"

+#include "core/inspector/MainThreadDebugger.h"

#include "public/platform/Platform.h"

#include "wtf/MainThread.h"

@@ -277,7 +277,7 @@ void V8PerIsolateData::clearEndOfScopeTasks()

m_endOfScopeTasks.clear();

}

-void V8PerIsolateData::setScriptDebugger(PassOwnPtr<ScriptDebuggerBase> debugger)

+void V8PerIsolateData::setScriptDebugger(PassOwnPtr<MainThreadDebugger> debugger)

{

ASSERT(!m_scriptDebugger);

m_scriptDebugger = debugger;