src/device/xps/SkXPSDevice.cpp - Issue 1514503004: SkBitmap move

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/device/xps/SkXPSDevice.cpp

Issue 1514503004: SkBitmap move (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: 2015-12-10 (Thursday) 17:55:13 EST Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/device/xps/SkXPSDevice.cpp

diff --git a/src/device/xps/SkXPSDevice.cpp b/src/device/xps/SkXPSDevice.cpp

index 86c729c9e405cd516f062e69ac87da01e442ccc9..2dc84c5a6c1122c53b93b34a3d45dffd18ab5e2e 100644

--- a/src/device/xps/SkXPSDevice.cpp

+++ b/src/device/xps/SkXPSDevice.cpp

@@ -108,7 +108,7 @@ HRESULT SkXPSDevice::createId(wchar_t* buffer, size_t bufferSize, wchar_t sep) {

static SkBitmap make_fake_bitmap(int width, int height) {

SkBitmap bitmap;

bitmap.setInfo(SkImageInfo::MakeUnknown(width, height));

- return bitmap;

+ return skstd::move(bitmap);

}

// TODO: should inherit from SkBaseDevice instead of SkBitmapDevice...