Show Incognito tab switcher button on startup

Show Incognito tab switcher button on startup

LayoutManagerChrome now observes the TabModelSelector to see
if any Incognito tabs exist during startup.  If so, it signals
to the Layout that the Incognito tab switcher button should be
visible.

BUG=543885
Committed: https://crrev.com/cd5e837062a24f403b9453f8a06929c0f5b10982
Cr-Commit-Position: refs/heads/master@{#364225}

[gone, 2015-12-09 02:12:38]

dfalcantara@chromium.org changed reviewers:
+ dtrainor@chromium.org

[David Trainor- moved to gerrit, 2015-12-09 16:16:27]

lgtm

[David Trainor- moved to gerrit, 2015-12-09 16:16:55]

On 2015/12/09 16:16:27, David Trainor wrote:
> lgtm

Actually, can you put this in LayoutManagerDocument (or even just the base
LayoutManager class)?

[gone, 2015-12-09 18:06:27]

Sure... does it make sense to remove the Observer when we're done waiting for
initialization, btw?  Guessing an AsyncTask to avoid weird situations where we
remove things out of order?

[gone, 2015-12-09 18:09:27]

On 2015/12/09 18:06:27, dfalcantara wrote:
> Sure... does it make sense to remove the Observer when we're done waiting for
> initialization, btw?  Guessing an AsyncTask to avoid weird situations where we
> remove things out of order?

Probably a runnable, actually.

[gone, 2015-12-09 18:49:03]

Did the runnable thing.  PTAL.

https://codereview.chromium.org/1514503002/diff/40001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
(right):

https://codereview.chromium.org/1514503002/diff/40001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java:547:
final EmptyTabModelSelectorObserver observer = this;
Had to put this here because trying to reference the
EmptyTabModelSelectorObserver from inside the Runnable was failing in every
other way I tried ("observer is uninitialized" or "EmptyTabModelSelectorObserver
is not an outer class of Runnable").

[David Trainor- moved to gerrit, 2015-12-09 21:44:15]

lgtm

https://chromiumcodereview.appspot.com/1514503002/diff/40001/chrome/android/j...
File
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java
(right):

https://chromiumcodereview.appspot.com/1514503002/diff/40001/chrome/android/j...
chrome/android/java/src/org/chromium/chrome/browser/compositor/layouts/LayoutManager.java:547:
final EmptyTabModelSelectorObserver observer = this;
On 2015/12/09 18:49:03, dfalcantara wrote:
> Had to put this here because trying to reference the
> EmptyTabModelSelectorObserver from inside the Runnable was failing in every
> other way I tried ("observer is uninitialized" or
"EmptyTabModelSelectorObserver
> is not an outer class of Runnable").

Yay Java!  No worries this seems fine.

[gone, 2015-12-09 22:02:50]

The CQ bit was checked by dfalcantara@chromium.org

[commit-bot: I haz the power, 2015-12-09 22:09:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1514503002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1514503002/40001

[commit-bot: I haz the power, 2015-12-10 00:06:42]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-12-10 00:07:45]

Description was changed from

==========
Show Incognito tab switcher button on startup

LayoutManagerChrome now observes the TabModelSelector to see
if any Incognito tabs exist during startup.  If so, it signals
to the Layout that the Incognito tab switcher button should be
visible.

BUG=543885
==========

to

==========
Show Incognito tab switcher button on startup

LayoutManagerChrome now observes the TabModelSelector to see
if any Incognito tabs exist during startup.  If so, it signals
to the Layout that the Incognito tab switcher button should be
visible.

BUG=543885

Committed: https://crrev.com/cd5e837062a24f403b9453f8a06929c0f5b10982
Cr-Commit-Position: refs/heads/master@{#364225}
==========

[commit-bot: I haz the power, 2015-12-10 00:07:46]

Patchset 3 (id:??) landed as
https://crrev.com/cd5e837062a24f403b9453f8a06929c0f5b10982
Cr-Commit-Position: refs/heads/master@{#364225}