Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1514483006: Wrap new API in a try-catch. (Closed)

Created:
5 years ago by David Tseng
Modified:
5 years ago
Reviewers:
dmazzoni
CC:
chromium-reviews, oshima+watch_chromium.org, plundblad+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, arv+watch_chromium.org, dtseng+watch_chromium.org, dmazzoni+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Wrap new API in a try-catch. Since the webstore release cannot (at the moment) be tied to any particular version of Chrome, something like this is necessary to prevent us from crashing. TEST=load into Chrome stable; verify we still come up talking. Committed: https://crrev.com/5c11f1846badc760e279ad4a7907cc8e45b92fa9 Cr-Commit-Position: refs/heads/master@{#364471}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/live_regions.js View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
David Tseng
5 years ago (2015-12-10 19:22:51 UTC) #3
dmazzoni
lgtm
5 years ago (2015-12-10 20:11:18 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1514483006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1514483006/1
5 years ago (2015-12-10 20:13:02 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years ago (2015-12-10 20:59:31 UTC) #8
commit-bot: I haz the power
5 years ago (2015-12-10 21:00:30 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c11f1846badc760e279ad4a7907cc8e45b92fa9
Cr-Commit-Position: refs/heads/master@{#364471}

Powered by Google App Engine
This is Rietveld 408576698