Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 1514483003: Fix datetime test. (Closed)

Created:
5 years ago by floitsch
Modified:
5 years ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/corelib/date_time_test.dart View 1 chunk +1 line, -1 line 4 comments Download

Messages

Total messages: 6 (2 generated)
floitsch
TBR.
5 years ago (2015-12-09 01:56:43 UTC) #2
floitsch
Committed patchset #1 (id:1) manually as db643f5ae217e6af3f97d5738e2f0fb0cf327ece (presubmit successful).
5 years ago (2015-12-09 01:57:10 UTC) #4
Lasse Reichstein Nielsen
https://codereview.chromium.org/1514483003/diff/1/tests/corelib/date_time_test.dart File tests/corelib/date_time_test.dart (right): https://codereview.chromium.org/1514483003/diff/1/tests/corelib/date_time_test.dart#newcode45 tests/corelib/date_time_test.dart:45: if (!supportsMicroseconds) return; Why test this here, and not ...
5 years ago (2015-12-09 06:11:28 UTC) #5
floitsch
5 years ago (2015-12-09 06:17:55 UTC) #6
Message was sent while issue was closed.
https://codereview.chromium.org/1514483003/diff/1/tests/corelib/date_time_tes...
File tests/corelib/date_time_test.dart (right):

https://codereview.chromium.org/1514483003/diff/1/tests/corelib/date_time_tes...
tests/corelib/date_time_test.dart:45: if (!supportsMicroseconds) return;
On 2015/12/09 06:11:28, Lasse Reichstein Nielsen wrote:
> Why test this here, and not above? Why test it at all?

The tests above should work for independently if microseconds are supported or
not. So I left the test.

https://codereview.chromium.org/1514483003/diff/1/tests/corelib/date_time_tes...
tests/corelib/date_time_test.dart:47: microsecondsSinceEpoch =
dt1.millisecondsSinceEpoch;
On 2015/12/09 06:11:28, Lasse Reichstein Nielsen wrote:
> Same here?

argh.
Will do a follow-up CL.

Powered by Google App Engine
This is Rietveld 408576698