Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(764)

Unified Diff: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js

Issue 1514483002: DevTools: brush up new details cards on timeline. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
diff --git a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
index 8682ffb475f1cd4ae101da8ae936a16e9658952e..87d5c2c38b20ec71f8a6284da339f9ed2388116a 100644
--- a/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
+++ b/third_party/WebKit/Source/devtools/front_end/components/DOMPresentationUtils.js
@@ -224,6 +224,7 @@ WebInspector.DOMPresentationUtils.buildStackTracePreviewContents = function(targ
element.style.display = "inline-block";
var shadowRoot = WebInspector.createShadowRootWithCoreStyles(element, "components/domUtils.css");
var contentElement = shadowRoot.createChild("table", "stack-preview-container");
+ contentElement.setAttribute("cellSpacing", "0");
/**
* @param {!Array.<!ConsoleAgent.CallFrame>} stackTrace
@@ -233,7 +234,6 @@ WebInspector.DOMPresentationUtils.buildStackTracePreviewContents = function(targ
for (var stackFrame of stackTrace) {
var row = createElement("tr");
row.createChild("td").textContent = WebInspector.beautifyFunctionName(stackFrame.functionName);
- row.createChild("td").textContent = " @ ";
row.createChild("td").appendChild(linkifier.linkifyConsoleCallFrame(target, stackFrame));
contentElement.appendChild(row);
}
@@ -249,7 +249,6 @@ WebInspector.DOMPresentationUtils.buildStackTracePreviewContents = function(targ
var row = contentElement.createChild("tr");
row.createChild("td", "stack-preview-async-description").textContent = WebInspector.asyncStackTraceLabel(asyncStackTrace.description);
row.createChild("td");
- row.createChild("td");
appendStackTrace(callFrames);
asyncStackTrace = asyncStackTrace.asyncStackTrace;
}

Powered by Google App Engine
This is Rietveld 408576698