Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3442)

Unified Diff: build/common.gypi

Issue 1514423003: Don't set -fvisibility=hidden for iOS Debug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | build/config/gcc/BUILD.gn » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index b81acbe25aecc1db418a72e93bbbc55600b81629..83559deb87f4be3bfa0f4883f5df19a24d80e393 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -5073,7 +5073,6 @@
# GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden
'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors
- 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics
'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
'GCC_VERSION': '4.2',
@@ -5135,16 +5134,35 @@
'-fcolor-diagnostics',
],
}],
- ['OS=="ios" and target_subarch!="arm32" and \
- "<(GENERATOR)"=="xcode"', {
- 'OTHER_CFLAGS': [
- # TODO(ios): when building Chrome for iOS on 64-bit platform
- # with Xcode, the -Wshorted-64-to-32 warning is automatically
- # enabled. This cause failures when compiling protobuf code,
- # so disable the warning. http://crbug.com/359107
- '-Wno-shorten-64-to-32',
+ ['OS=="ios"', {
+ 'configurations': {
+ 'Debug': {
+ # XCTests inject a dynamic library into the application. If
+ # fvisibility is set to hidden, then some symbols needed by
+ # XCTests are not available. Disable this setting for
+ # Debug configuration.
+ 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
+ },
+ 'Release': {
+ 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
+ },
+ },
+ 'conditions': [
+ ['target_subarch!="arm32" and "<(GENERATOR)"=="xcode"', {
+ 'OTHER_CFLAGS': [
+ # TODO(ios): when building Chrome for iOS on 64-bit
+ # platform with Xcode, the -Wshorted-64-to-32 warning is
+ # automatically enabled. This causes failures when
+ # compiling protobuf code, so disable the warning.
+ # http://crbug.com/359107
+ '-Wno-shorten-64-to-32',
+ ],
+ }],
],
}],
+ ['OS=="mac"', {
+ 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
+ }],
],
},
'conditions': [
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | build/config/gcc/BUILD.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698