Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1190)

Unified Diff: build/config/gcc/BUILD.gn

Issue 1514423003: Don't set -fvisibility=hidden for iOS Debug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/gcc/BUILD.gn
diff --git a/build/config/gcc/BUILD.gn b/build/config/gcc/BUILD.gn
index 2c1c61f6afd10d7ad439155642da1576cd47fd5e..c7afcdf544f2b5ad1799cc922ff7ba13f7344a30 100644
--- a/build/config/gcc/BUILD.gn
+++ b/build/config/gcc/BUILD.gn
@@ -18,7 +18,14 @@ import("//build/toolchain/toolchain.gni")
config("symbol_visibility_hidden") {
# Note that -fvisibility-inlines-hidden is set globally in the compiler
# config since that can almost always be applied.
- cflags = [ "-fvisibility=hidden" ]
+
+ # XCTests inject a dynamic library into an iOS application. If fvisibility
+ # is set to hidden, then some symbols from the application needed by XCTests
+ # may not be available. XCTests are used for iOS integration tests. Make sure
+ # all symbols are exported for Debug configurations on iOS.
+ if (!is_ios || !is_debug) {
+ cflags = [ "-fvisibility=hidden" ]
+ }
}
# The rpath is the dynamic library search path. Setting this config on a link
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698