Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Side by Side Diff: build/common.gypi

Issue 1514423003: Don't set -fvisibility=hidden for iOS Debug. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update gn Created 5 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | build/config/BUILDCONFIG.gn » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 # IMPORTANT: 5 # IMPORTANT:
6 # Please don't directly include this file if you are building via gyp_chromium, 6 # Please don't directly include this file if you are building via gyp_chromium,
7 # since gyp_chromium is automatically forcing its inclusion. 7 # since gyp_chromium is automatically forcing its inclusion.
8 { 8 {
9 # Variables expected to be overriden on the GYP command line (-D) or by 9 # Variables expected to be overriden on the GYP command line (-D) or by
10 # ~/.gyp/include.gypi. 10 # ~/.gyp/include.gypi.
(...skipping 5055 matching lines...) Expand 10 before | Expand all | Expand 10 after
5066 'CLANG_LINK_OBJC_RUNTIME': 'NO', # -fno-objc-link-runtime 5066 'CLANG_LINK_OBJC_RUNTIME': 'NO', # -fno-objc-link-runtime
5067 'COPY_PHASE_STRIP': 'NO', 5067 'COPY_PHASE_STRIP': 'NO',
5068 'GCC_C_LANGUAGE_STANDARD': 'c99', # -std=c99 5068 'GCC_C_LANGUAGE_STANDARD': 'c99', # -std=c99
5069 'GCC_CW_ASM_SYNTAX': 'NO', # No -fasm-blocks 5069 'GCC_CW_ASM_SYNTAX': 'NO', # No -fasm-blocks
5070 'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions 5070 'GCC_ENABLE_CPP_EXCEPTIONS': 'NO', # -fno-exceptions
5071 'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti 5071 'GCC_ENABLE_CPP_RTTI': 'NO', # -fno-rtti
5072 'GCC_ENABLE_PASCAL_STRINGS': 'NO', # No -mpascal-strings 5072 'GCC_ENABLE_PASCAL_STRINGS': 'NO', # No -mpascal-strings
5073 # GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden 5073 # GCC_INLINES_ARE_PRIVATE_EXTERN maps to -fvisibility-inlines-hidden
5074 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES', 5074 'GCC_INLINES_ARE_PRIVATE_EXTERN': 'YES',
5075 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors 5075 'GCC_OBJC_CALL_CXX_CDTORS': 'YES', # -fobjc-call-cxx-cdtors
5076 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5077 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics 5076 'GCC_THREADSAFE_STATICS': 'NO', # -fno-threadsafe-statics
5078 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror 5077 'GCC_TREAT_WARNINGS_AS_ERRORS': 'YES', # -Werror
5079 'GCC_VERSION': '4.2', 5078 'GCC_VERSION': '4.2',
5080 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof 5079 'GCC_WARN_ABOUT_MISSING_NEWLINE': 'YES', # -Wnewline-eof
5081 'USE_HEADERMAP': 'NO', 5080 'USE_HEADERMAP': 'NO',
5082 'WARNING_CFLAGS': [ 5081 'WARNING_CFLAGS': [
5083 '-Wall', 5082 '-Wall',
5084 '-Wextra', 5083 '-Wextra',
5085 # Don't warn about unused function parameters. 5084 # Don't warn about unused function parameters.
5086 '-Wno-unused-parameter', 5085 '-Wno-unused-parameter',
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
5128 'OTHER_CFLAGS': [ 5127 'OTHER_CFLAGS': [
5129 '-Xclang', '-add-plugin', '-Xclang', '<(clang_add_plugin)', 5128 '-Xclang', '-add-plugin', '-Xclang', '<(clang_add_plugin)',
5130 ], 5129 ],
5131 }], 5130 }],
5132 ['clang==1 and "<(GENERATOR)"=="ninja"', { 5131 ['clang==1 and "<(GENERATOR)"=="ninja"', {
5133 'OTHER_CFLAGS': [ 5132 'OTHER_CFLAGS': [
5134 # See http://crbug.com/110262 5133 # See http://crbug.com/110262
5135 '-fcolor-diagnostics', 5134 '-fcolor-diagnostics',
5136 ], 5135 ],
5137 }], 5136 }],
5138 ['OS=="ios" and target_subarch!="arm32" and \ 5137 ['OS=="ios"', {
5139 "<(GENERATOR)"=="xcode"', { 5138 'configurations': {
5140 'OTHER_CFLAGS': [ 5139 'Debug': {
5141 # TODO(ios): when building Chrome for iOS on 64-bit platform 5140 # XCTests inject a dynamic library into the application. If
5142 # with Xcode, the -Wshorted-64-to-32 warning is automatically 5141 # fvisibility is set to hidden, then some symbols needed by
5143 # enabled. This cause failures when compiling protobuf code, 5142 # XCTests are not available. Disable this setting for
5144 # so disable the warning. http://crbug.com/359107 5143 # Debug configuration.
5145 '-Wno-shorten-64-to-32', 5144 'GCC_SYMBOLS_PRIVATE_EXTERN': 'NO',
5145 },
5146 'Release': {
5147 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5148 },
5149 },
5150 'conditions': [
5151 ['target_subarch!="arm32" and "<(GENERATOR)"=="xcode"', {
5152 'OTHER_CFLAGS': [
5153 # TODO(ios): when building Chrome for iOS on 64-bit
5154 # platform with Xcode, the -Wshorted-64-to-32 warning is
5155 # automatically enabled. This causes failures when
5156 # compiling protobuf code, so disable the warning.
5157 # http://crbug.com/359107
5158 '-Wno-shorten-64-to-32',
5159 ],
5160 }],
5146 ], 5161 ],
5147 }], 5162 }],
5163 ['OS=="mac"', {
5164 'GCC_SYMBOLS_PRIVATE_EXTERN': 'YES', # -fvisibility=hidden
5165 }],
5148 ], 5166 ],
5149 }, 5167 },
5150 'conditions': [ 5168 'conditions': [
5151 ['clang==1', { 5169 ['clang==1', {
5152 'variables': { 5170 'variables': {
5153 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin', 5171 'clang_dir': '../third_party/llvm-build/Release+Asserts/bin',
5154 }, 5172 },
5155 }], 5173 }],
5156 ['asan==1', { 5174 ['asan==1', {
5157 'xcode_settings': { 5175 'xcode_settings': {
(...skipping 1251 matching lines...) Expand 10 before | Expand all | Expand 10 after
6409 # settings in target dicts. SYMROOT is a special case, because many other 6427 # settings in target dicts. SYMROOT is a special case, because many other
6410 # Xcode variables depend on it, including variables such as 6428 # Xcode variables depend on it, including variables such as
6411 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something 6429 # PROJECT_DERIVED_FILE_DIR. When a source group corresponding to something
6412 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the 6430 # like PROJECT_DERIVED_FILE_DIR is added to a project, in order for the
6413 # files to appear (when present) in the UI as actual files and not red 6431 # files to appear (when present) in the UI as actual files and not red
6414 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR, 6432 # red "missing file" proxies, the correct path to PROJECT_DERIVED_FILE_DIR,
6415 # and therefore SYMROOT, needs to be set at the project level. 6433 # and therefore SYMROOT, needs to be set at the project level.
6416 'SYMROOT': '<(DEPTH)/xcodebuild', 6434 'SYMROOT': '<(DEPTH)/xcodebuild',
6417 }, 6435 },
6418 } 6436 }
OLDNEW
« no previous file with comments | « no previous file | build/config/BUILDCONFIG.gn » ('j') | build/config/BUILDCONFIG.gn » ('J')

Powered by Google App Engine
This is Rietveld 408576698