src/compiler/instruction.h - Issue 1514413002: [Interpreter] Generate valid FrameStates in the Bytecode Graph Builder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler/instruction.h

Issue 1514413002: [Interpreter] Generate valid FrameStates in the Bytecode Graph Builder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@int_materialize_sf

Patch Set: Add checks that environment doesn't change after state nodes are attached Created 5 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/compiler/instruction.h

diff --git a/src/compiler/instruction.h b/src/compiler/instruction.h

index 594e6de5044c0de3c8190cd5510eeca2a7e61048..4e4ffdbf729c557c73408619b8c1d86cfa6d4aa7 100644

--- a/src/compiler/instruction.h

+++ b/src/compiler/instruction.h

@@ -954,7 +954,7 @@ class FrameStateDescriptor : public ZoneObject {

MaybeHandle<SharedFunctionInfo> shared_info() const { return shared_info_; }

FrameStateDescriptor* outer_state() const { return outer_state_; }

bool HasContext() const {

- return type_ == FrameStateType::kJavaScriptFunction;

+ return FrameStateFunctionInfo::IsJSFunctionType(type_);

}

size_t GetSize(OutputFrameStateCombine combine =

« no previous file with comments | « src/compiler/frame-states.cc ('k') | src/compiler/instruction.cc » ('j') | no next file with comments »